1169225 - [MobileConnectionService] Support setting/getting call waiting on all serviceClass

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Now MobileConnectionService.{set|get}CallWaiting() support voice only, I would like make this api can support all serviceClass. This also benefits bug 1159591, because we can reuse those API for MMI operation.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 3

[Edgar Chen [:edgar]]

Attachment: Patch, v3

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8615135 [details] [diff] [review]
Patch, v3

Review of attachment 8615135 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Aknow, may I have your review? Thank you.

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8615135 [details] [diff] [review]
Patch, v3

Review of attachment 8615135 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thank you.

::: dom/mobileconnection/tests/marionette/test_call_waiting.js
@@ +13,5 @@
> +    // error here.
> +    .then(() => setCallWaitingOption(true))
> +    .then(() => {
> +      ok(false, "setCallWaitingOption should not success");
> +    }, (aError) => {

aError
'()' is not necessary.

@@ +21,5 @@
> +
> +    .then(() => getCallWaitingOption())
> +    .then(() => {
> +      ok(false, "getCallWaitingOption should not success");
> +    }, (aError) => {

aError

Comment 6

[Edgar Chen [:edgar]]

Attachment: Patch, v4, r=aknow

Address review comment #5.

Comment 7

[Edgar Chen [:edgar]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9c34d92f7f6

Comment 8

[Edgar Chen [:edgar]]

Attachment: Patch, v5, r=aknow

Fix xpcshell tests.

Comment 9

[Edgar Chen [:edgar]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be44db56403

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/64eac64e048c

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/64eac64e048c