Closed Bug 1169225 Opened 9 years ago Closed 9 years ago

[MobileConnectionService] Support setting/getting call waiting on all serviceClass

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S14 (12june)
Tracking Status
firefox41 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file, 4 obsolete files)

Now MobileConnectionService.{set|get}CallWaiting() support voice only, I would like make this api can support all serviceClass. This also benefits bug 1159591, because we can reuse those API for MMI operation.
Blocks: 1159591
Attached patch Patch, v1 (obsolete) — Splinter Review
Assignee: nobody → echen
Attached patch Patch, v2 (obsolete) — Splinter Review
Attachment #8614611 - Attachment is obsolete: true
Attached patch Patch, v3 (obsolete) — Splinter Review
Attachment #8614614 - Attachment is obsolete: true
Comment on attachment 8615135 [details] [diff] [review]
Patch, v3

Review of attachment 8615135 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Aknow, may I have your review? Thank you.
Attachment #8615135 - Flags: review?(szchen)
Comment on attachment 8615135 [details] [diff] [review]
Patch, v3

Review of attachment 8615135 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thank you.

::: dom/mobileconnection/tests/marionette/test_call_waiting.js
@@ +13,5 @@
> +    // error here.
> +    .then(() => setCallWaitingOption(true))
> +    .then(() => {
> +      ok(false, "setCallWaitingOption should not success");
> +    }, (aError) => {

aError
'()' is not necessary.

@@ +21,5 @@
> +
> +    .then(() => getCallWaitingOption())
> +    .then(() => {
> +      ok(false, "getCallWaitingOption should not success");
> +    }, (aError) => {

aError
Attachment #8615135 - Flags: review?(szchen) → review+
Attached patch Patch, v4, r=aknow (obsolete) — Splinter Review
Address review comment #5.
Attachment #8615135 - Attachment is obsolete: true
Attachment #8616621 - Flags: review+
Fix xpcshell tests.
Attachment #8616621 - Attachment is obsolete: true
Attachment #8620781 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/64eac64e048c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: