Closed
Bug 1169225
Opened 9 years ago
Closed 9 years ago
[MobileConnectionService] Support setting/getting call waiting on all serviceClass
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
2.2 S14 (12june)
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file, 4 obsolete files)
23.58 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
Now MobileConnectionService.{set|get}CallWaiting() support voice only, I would like make this api can support all serviceClass. This also benefits bug 1159591, because we can reuse those API for MMI operation.
Assignee | ||
Updated•9 years ago
|
Blocks: b2g-ril-interface
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → echen
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8614611 -
Attachment is obsolete: true
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8614614 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8615135 [details] [diff] [review] Patch, v3 Review of attachment 8615135 [details] [diff] [review]: ----------------------------------------------------------------- Hi Aknow, may I have your review? Thank you.
Attachment #8615135 -
Flags: review?(szchen)
Comment 5•9 years ago
|
||
Comment on attachment 8615135 [details] [diff] [review] Patch, v3 Review of attachment 8615135 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thank you. ::: dom/mobileconnection/tests/marionette/test_call_waiting.js @@ +13,5 @@ > + // error here. > + .then(() => setCallWaitingOption(true)) > + .then(() => { > + ok(false, "setCallWaitingOption should not success"); > + }, (aError) => { aError '()' is not necessary. @@ +21,5 @@ > + > + .then(() => getCallWaitingOption()) > + .then(() => { > + ok(false, "getCallWaitingOption should not success"); > + }, (aError) => { aError
Attachment #8615135 -
Flags: review?(szchen) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Address review comment #5.
Attachment #8615135 -
Attachment is obsolete: true
Attachment #8616621 -
Flags: review+
Assignee | ||
Comment 7•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9c34d92f7f6
Assignee | ||
Comment 8•9 years ago
|
||
Fix xpcshell tests.
Attachment #8616621 -
Attachment is obsolete: true
Attachment #8620781 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be44db56403
https://hg.mozilla.org/mozilla-central/rev/64eac64e048c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in
before you can comment on or make changes to this bug.
Description
•