1169227 - "Short URL" fails on any new query - I don't get a link

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Wayne Mery (:wsmwk)]

Today, "Short URL" fails on any new query - I don't get a link.
It does however work for old queries that are open in my browser.

Perhaps caused  by this morning's BMO push?  (as posted in newsgroup 3am EST)

Comment 1

[:glob ✱]

YAHOO.util.Connect undefined.

we should probably fix this one by converting the bitly extension to use jquery.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1169227_1.patch

Fixing this with jquery is the right long term solution. Tried jquery-ui's Dialog, but it doesn't really compare favorably to the existing yui-overlay. 

:glob -> What were you thinking of using for the overlay ui? 

How about a one line fix for the yui for the moment?

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1169227_2.patch

wrong one. The module is 'connection'.

Comment 4

[:glob ✱]

Comment on attachment 8612544 [details] [diff] [review]
1169227_2.patch

Review of attachment 8612544 [details] [diff] [review]:
-----------------------------------------------------------------

> How about a one line fix for the yui for the moment?
makes sense..  i'd forgotten about the ui part to be honest.  we'll have to find a non-jquery-ui fix for that.

r=glob

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   d0acf50..495e38b  master -> master

Comment 6

[:glob ✱]

json is also required:

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   a3a2ced..805054a  master -> master

Comment 7

[Wayne Mery (:wsmwk)]

Ta-da!  Looks better.