Closed Bug 1169227 Opened 9 years ago Closed 9 years ago

"Short URL" fails on any new query - I don't get a link

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Product:
bugzilla.mozilla.org
Component:
Extensions
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: wsmwk, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

1169227_2.patch
631 bytes, patch
glob
: review+
Details | Diff | Splinter Review 
Today, "Short URL" fails on any new query - I don't get a link.
It does however work for old queries that are open in my browser.

Perhaps caused  by this morning's BMO push?  (as posted in newsgroup 3am EST)
YAHOO.util.Connect undefined.

we should probably fix this one by converting the bitly extension to use jquery.
Component: Extensions: BMO → Extensions: Other
Assignee: nobody → dylan
Attached patch 1169227_1.patch (obsolete) — — Splinter Review 
Fixing this with jquery is the right long term solution. Tried jquery-ui's Dialog, but it doesn't really compare favorably to the existing yui-overlay. 

:glob -> What were you thinking of using for the overlay ui? 

How about a one line fix for the yui for the moment?
Attachment #8612538 - Flags: review?(glob)
Attached patch 1169227_2.patch — — Splinter Review 
wrong one. The module is 'connection'.
Attachment #8612538 - Attachment is obsolete: true
Attachment #8612538 - Flags: review?(glob)
Attachment #8612544 - Flags: review?(glob)
Comment on attachment 8612544 [details] [diff] [review]
1169227_2.patch

Review of attachment 8612544 [details] [diff] [review]:
-----------------------------------------------------------------

> How about a one line fix for the yui for the moment?
makes sense..  i'd forgotten about the ui part to be honest.  we'll have to find a non-jquery-ui fix for that.

r=glob
Attachment #8612544 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   d0acf50..495e38b  master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
json is also required:

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   a3a2ced..805054a  master -> master
Ta-da!  Looks better.
Status: RESOLVED → VERIFIED
Assignee: dylan → nobody
Component: Extensions: Other → Extensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: