1169232 - [gtk3] White text on grey background on notification toolbar.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Screenshot.png

I assume this is true for other info bars, although it doesn't happen for the telemetry thing.

See attached screenshot.

Comment 1

[Mike Hommey [:glandium]]

This is the CSS fragment corresponding to the style of those infobars:

http://hg.mozilla.org/mozilla-central/file/baa9c64fea6f/toolkit/themes/linux/global/notification.css#l7

So InfoText must be wrong.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

1011     gtk_style_context_add_class(style, GTK_STYLE_CLASS_TOOLTIP);
1012     gtk_style_context_get_background_color(style, GTK_STATE_FLAG_NORMAL, &color);
1013     sInfoBackground = GDK_RGBA_TO_NS_RGBA(color);
1014     gtk_style_context_get_color(style, GTK_STATE_FLAG_NORMAL, &color);
1015     sInfoText = GDK_RGBA_TO_NS_RGBA(color);
1016     g_object_unref(style);

Comment 3

[Martin Stránský [:stransky] (ni? me)]

IMHO it should also use tooltip background (which is black) or choose a different text color.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Actually the bug is caused by transparent tooltip background color which is defined by Gtk3 themes.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: tooltip-background.patch

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Unfortunately it breaks all kind of notifications like addon updates and so.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8012d33b7c71

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92c770d9b2cc

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/92c770d9b2cc