Closed
Bug 1169309
Opened 10 years ago
Closed 10 years ago
Separate the concat from the pretranslate step
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
2.2 S14 (12june)
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | fixed |
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
These two operations are now done together. We could clean the code up a bit by separating them.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → stas
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8612347 -
Flags: review?(rchien)
|
||
Updated•10 years ago
|
Attachment #8612347 -
Flags: review?(rchien) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
I think I accidentally fixed a bug with pretranslation. On current master, GAIA_DEFAULT_LOCALE correctly sets the lang and dir attributes on <html> but doesn't actually localize the DOM. I'm not sure why, but my PR appears to have fixed this.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Clarification: this only happens to qps-* locales.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Hey Ricky, thanks for the review. I'd like to have a quick question before I'm ready to merge this. I realized that this._optimize was only called when the document was localization-enabled, i.e. it linked to l10n.js and definded localization resources. Was this intended? I'll keep this the same way in the PR, but I'm wondering if it was a bug.
https://github.com/mozilla-b2g/gaia/pull/30291#discussion_r31310121
Flags: needinfo?(rchien)
|
|
||
Comment 5•10 years ago
|
||
Yah, it's bug. We should do optimize event if there's no l10n.js nor localization in html but only ignore l10n optimize method. We should file a bug to fix it.
Flags: needinfo?(rchien)
|
|
||
Comment 6•10 years ago
|
||
file bug 1170899 for it.
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in
before you can comment on or make changes to this bug.
Description
•