These two operations are now done together. We could clean the code up a bit by separating them.
Created attachment 8612347 [details] [review] [gaia] stasm:1169309-separate-concat-pretranslate > mozilla-b2g:master
Attachment #8612347 - Flags: review?(rchien) → review+
I think I accidentally fixed a bug with pretranslation. On current master, GAIA_DEFAULT_LOCALE correctly sets the lang and dir attributes on <html> but doesn't actually localize the DOM. I'm not sure why, but my PR appears to have fixed this.
Clarification: this only happens to qps-* locales.
Hey Ricky, thanks for the review. I'd like to have a quick question before I'm ready to merge this. I realized that this._optimize was only called when the document was localization-enabled, i.e. it linked to l10n.js and definded localization resources. Was this intended? I'll keep this the same way in the PR, but I'm wondering if it was a bug. https://github.com/mozilla-b2g/gaia/pull/30291#discussion_r31310121
Yah, it's bug. We should do optimize event if there's no l10n.js nor localization in html but only ignore l10n optimize method. We should file a bug to fix it.
file bug 1170899 for it.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-master: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.