Separate the concat from the pretranslate step

RESOLVED FIXED in 2.2 S14 (12june)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: stas, Assigned: stas)

Tracking

unspecified
2.2 S14 (12june)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-master fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
These two operations are now done together.  We could clean the code up a bit by separating them.
Created attachment 8612347 [details] [review]
[gaia] stasm:1169309-separate-concat-pretranslate > mozilla-b2g:master
(Assignee)

Updated

4 years ago
Assignee: nobody → stas
(Assignee)

Updated

4 years ago
Attachment #8612347 - Flags: review?(rchien)
(Assignee)

Updated

4 years ago
Blocks: 1169361
Attachment #8612347 - Flags: review?(rchien) → review+
(Assignee)

Comment 2

4 years ago
I think I accidentally fixed a bug with pretranslation.  On current master, GAIA_DEFAULT_LOCALE correctly sets the lang and dir attributes on <html> but doesn't actually localize the DOM.  I'm not sure why, but my PR appears to have fixed this.
(Assignee)

Comment 3

4 years ago
Clarification:  this only happens to qps-* locales.
(Assignee)

Comment 4

4 years ago
Hey Ricky, thanks for the review.  I'd like to have a quick question before I'm ready to merge this.  I realized that this._optimize was only called when the document was localization-enabled, i.e. it linked to l10n.js and definded localization resources. Was this intended? I'll keep this the same way in the PR, but I'm wondering if it was a bug.

https://github.com/mozilla-b2g/gaia/pull/30291#discussion_r31310121
Flags: needinfo?(rchien)
Yah, it's bug. We should do optimize event if there's no l10n.js nor localization in html but only ignore l10n optimize method. We should file a bug to fix it.
Flags: needinfo?(rchien)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/ee8bc41672792e0daa37e5bb2f7700d2653d4231
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.