1169327 - Set the webapps.update.enabled pref to false in gaia_test.py and remove the fake update checker code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

The fake update checker code doesn't seem to work, currently, which causes issues like bug 1167958.
From the discussion in that bug, it turns out there is the webapps.update.enabled pref, which disables webapps update checking.

We should just use that and remove the fake update checker.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1169327 > mozilla-b2g:master

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1169327_2 > mozilla-b2g:master

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8612853 [details] [review]
[gaia] mwargers:1169327 > mozilla-b2g:master

See comments in pull request.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8612860 [details] [review]
[gaia] mwargers:1169327_2 > mozilla-b2g:master

If this is broken and we have a better solution (the preference) then r+ and no need to wait for the other patch to land before landing this one.

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8612853 [details] [review]
[gaia] mwargers:1169327 > mozilla-b2g:master

Ok, updated the pull request with your comments. Let me know what you think.

Comment 6

[Martijn Wargers (dead)]

(In reply to Dave Hunt (:davehunt) from comment #4)
> Comment on attachment 8612860 [details] [review]
> [gaia] mwargers:1169327_2 > mozilla-b2g:master
> 
> If this is broken and we have a better solution (the preference) then r+ and
> no need to wait for the other patch to land before landing this one.

Ok, thanks, I merged this: https://github.com/mozilla-b2g/gaia/commit/4ac2e0e4f7ef9c863143a4d6da21afdeb8ab8940

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8612853 [details] [review]
[gaia] mwargers:1169327 > mozilla-b2g:master

Looks good, just a couple of comments. Also, could you run an adhoc build against this? Perhaps just the smoke tests would be fine.

Comment 8

[Martijn Wargers (dead)]

Updated the pull request and started an adhoc job on bitbar: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc.bitbar/67/

Comment 9

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #8)
> Updated the pull request and started an adhoc job on bitbar:
> http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc.bitbar/67/

Something went wrong, I created a new run here: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc.bitbar/68/

Comment 10

[Martijn Wargers (dead)]

Something went wrong in the bitbar run while trying to flash the device. I saw some mail coming by about that, but it was supposed to be fixed?

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #10)
> Something went wrong in the bitbar run while trying to flash the device. I
> saw some mail coming by about that, but it was supposed to be fixed?

Please do not use a 'latest' build URL - you will have no control over the build that's flashed to the device! I have retriggered with a known good build URL: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc.bitbar/69/

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8612853 [details] [review]
[gaia] mwargers:1169327 > mozilla-b2g:master

New patch looks good, let's hold off on merging until we get some results back from the adhoc build.

Comment 13

[Martijn Wargers (dead)]

Thanks for the bitbar run, it looked good (2 unrelated failures, I'll take a look at those).
Merged the first pull request now: https://github.com/mozilla-b2g/gaia/commit/42e112baea640c3b2665c5f050f695fc00daed78