1169370 - Scrollbar slider occasionally disappears on GTK3

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew Comminos [:acomminos]]

Occasionally, the page content's scrollbar slider will disappear on GTK 3.14 using Firefox built for GTK3.

The most consistent way to reproduce this (even though it can't be reproduced 100% of the time) is to attempt to scroll a page while it loads. The slider reappears when hovering over where one would expect the scrollbar slider to be.

Comment 1

[Andrew Comminos [:acomminos]]

Strangely, if OMTC is disabled, scrollbar sliders are never visible.

Comment 2

[Andrew Comminos [:acomminos]]

Attachment: Mark tree Cairo surface dirty after borrow.

The issue is caused by the fact that our tree cairo surface doesn't know that the underlying XLib surface has been modified on borrow when we draw widgets- it is believed to be clear. This patch marks it as dirty when the borrow ends, fixing the issue.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8620443 [details] [diff] [review]
Mark tree Cairo surface dirty after borrow.

Review of attachment 8620443 [details] [diff] [review]:
-----------------------------------------------------------------

We should also call cairo_surface_flush() in init()

Comment 4

[Andrew Comminos [:acomminos]]

Attachment: Mark tree Cairo surface dirty after borrow.

Flush the surface before the borrow begins, as per cairo docs.

Comment 5

[Carsten Book [:Tomcat]]

can we get a try run here, thanks!

Comment 6

[Andrew Comminos [:acomminos]]

GTK3 try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2dbcc52b7d5

Comment 7

[Andrew Comminos [:acomminos]]

Changes in bug 1129873 caused GTK3 try bustage, updated try with fix:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fb8ef159715

Comment 8

[Carsten Book [:Tomcat]]

(In reply to Andrew Comminos [:acomminos] from comment #7)
> Changes in bug 1129873 caused GTK3 try bustage, updated try with fix:
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fb8ef159715


this try run is full of failures like https://treeherder.mozilla.org/logviewer.html#?job_id=8451040&repo=try are those related to the patch ?

Comment 9

[Andrew Comminos [:acomminos]]

Unlikely; GTK3 builds currently aren't great on the test infrastructure (see https://treeherder.mozilla.org/#/jobs?repo=elm). Most of the failures are due to bug 1170342.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54386de97c76

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54386de97c76