1169379 - Replace top sites thumbnails with favicon-inspired design

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect)

Description

[Darrin Henein [:darrin]]

New mockup available here: http://invis.io/D43486ZVY

Titles should also become part of the tile, with a blurred background on top of the tile.

Tile background color should use one/more corner pixels of the favicon as a guide.

Use the biggest favicon available. Do not scale up. Max size is 62pt x 62pt, centered between title bar and top of tile.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: WIP PR https://github.com/mozilla/firefox-ios/pull/677

Darrin mentioned tweaking this a bit on IRC. Putting this up for UX to play with.

Comment 2

[Wesley Johnston (:wesj)]

Updated the PR to load favicons we don't have (only on the topsites panel). This is a bit complex (i.e. we load the HTML and parse with libxml (since it has an HTML parser), then download the images (storing them along the way) and return the largest one to you). Doesn't handle view recycling well right now, but TopSites doesn't really need that much anyway!

Many of the sites without icons are desktop ones (twitter/facebook), so we end up with less than ideal icons, but its better than nothing at all. Much better.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8630136 [details] [review]
WIP PR https://github.com/mozilla/firefox-ios/pull/677

This updates to the new design (blurred icon behind a non-blurred icon, text on the bottom, square tiles). It also includes a FaviconFetcher that will go find and store favicons for sites. That only runs on top sites, and it caches the results so it shouldn't happen frequently (for synced sites that don't have icons).

As I write that I realize sites that don't have icons at all could trigger it... I will dig into that (maybe we store a small default image if the fetcher finds nothing, and maybe we also set a max bytes we'd download here...)

In the grand tradition of me, I'd still rather look into reviewing/landing this while I dig in there a bit. I also noticed the queries are still too slow. Going to try entirely async loading of these icons to avoid some database joins (i.e. query the db for the history entries, then start a batch request for icons for visible sites separately).

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8630136 [details] [review]
WIP PR https://github.com/mozilla/firefox-ios/pull/677

Left some comments on the PR. The top sites panel looks great with the favicons!

Comment 5

[Richard Newman [:rnewman]]

I'm back if you want a third opinion on db stuff. Ping me on IRC!

Comment 6

[Stephan Leroux [:sleroux]]

:rnewman ya that would be great since I'm not too familiar with the DB changes

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8630136 [details] [review]
WIP PR https://github.com/mozilla/firefox-ios/pull/677

I switch to defferred here and realized that the entire getFromHost (which is still poorly named) method was doing way more than I needed it too. You mind looking at the top commit here?

Comment 8

[Wesley Johnston (:wesj)]

Landing

Comment 9

[Stephan Leroux [:sleroux]]

Comment on attachment 8630136 [details] [review]
WIP PR https://github.com/mozilla/firefox-ios/pull/677

Reviewed the top commit on the branch - looks good, just nits