1169402 - [e10s] Telemetry payloads from the child aren't propagating to the parent

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Jim Mathies [:jimm]]

AFAICT the stats object we fixed up in bug 1156857 is fixed. In debugging I see the histograms object accumulating data and telemetry seems to be working. However when we send a request from the parent for the child payload, nothing seems to happen.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetrySession.jsm#1708

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetrySession.jsm#1607

Comment 1

[Jim Mathies [:jimm]]

Components.utils.import("resource://gre/modules/TelemetrySession.jsm", this);
TelemetrySession.requestChildPayloads();
var payload = TelemetrySession.getPayload();
payload.childPayloads;

Comment 2

[Jim Mathies [:jimm]]

Still poking at this. I'm not sure what's going on here, but afaict TelemetryStartup isn't getting initialized. This or my dump output isn't getting to my console. Working on trying to confirm that presently.

FYI I will likely be on PTO tomorrow.

Comment 3

[Jim Mathies [:jimm]]

categories registered in the child:
**********************************
@mozilla.org/streamconv;1
Charset Decoders
Charset Encoders
Gecko-Content-Viewers
JavaScript-global-privileged-property
JavaScript-global-property
JavaScript-navigator-property
XSLT-extension-functions
addon-provider-module
agent-style-sheets
app-startup
bookmark-observers
charset-detectors
command-line-handler
content-policy
content-sniffing-services
external-uricontentlisteners
healthreport-js-provider-default
history-observers
idle-daily
module-loader
net-channel-event-sinks
net-content-sniffers
pref-config-startup
profile-after-change
update-timer
vacuum-participant
webapps-clear-data
xpcom-directory-providers
**********************************

app-startup entries:
**********************************
ContentProcessSingleton
PushNotificationService
Script Security Manager
TelemetryStartup
Window Data Source
**********************************

So manifest config and category manager appear to be configured right, but the module does not receive any app-startup observers. This also likely breaks ContentProcessSingleton.

Comment 4

[Jim Mathies [:jimm]]

> manifest config and category manager appear to be configured right, but
> the module does not receive any app-startup observers. This also likely
> breaks ContentProcessSingleton.

Turns out ContentProcessSingleton loads fine, TelemetryStartup does not.

Comment 5

[Jim Mathies [:jimm]]

Attachment: patch v.1

Ok, here's what's happening:

1) TelemetryStartup.js sources TelemetryEnvironment.jsm
2) TelemetryEnvironment.jsm sources AddonManager.jsm
3) AddonManager.jsm load errors out here - 
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#12

This breaks the app-startup init of telemetry in the content process. Since we don't use TelemetryEnvironment in the child here, I just switched it to a lazy getter.

Comment 6

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8614294 [details] [diff] [review]
patch v.1

Review of attachment 8614294 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.
As i'm working actively right now on Telemetry modifications, feel free to CC me on similar bugs.

Comment 7

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d0d7cc5740

Comment 8

[Jim Mathies [:jimm]]

Attachment: patch v.2

- updated commit

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fa1823420a8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6fa1823420a8