Closed
Bug 1169402
Opened 9 years ago
Closed 9 years ago
[e10s] Telemetry payloads from the child aren't propagating to the parent
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(1 file, 1 obsolete file)
1.84 KB,
patch
|
Details | Diff | Splinter Review |
AFAICT the stats object we fixed up in bug 1156857 is fixed. In debugging I see the histograms object accumulating data and telemetry seems to be working. However when we send a request from the parent for the child payload, nothing seems to happen. http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetrySession.jsm#1708 http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetrySession.jsm#1607
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jmathies
Assignee | ||
Comment 1•9 years ago
|
||
Components.utils.import("resource://gre/modules/TelemetrySession.jsm", this); TelemetrySession.requestChildPayloads(); var payload = TelemetrySession.getPayload(); payload.childPayloads;
Assignee | ||
Comment 2•9 years ago
|
||
Still poking at this. I'm not sure what's going on here, but afaict TelemetryStartup isn't getting initialized. This or my dump output isn't getting to my console. Working on trying to confirm that presently. FYI I will likely be on PTO tomorrow.
Assignee | ||
Comment 3•9 years ago
|
||
categories registered in the child: ********************************** @mozilla.org/streamconv;1 Charset Decoders Charset Encoders Gecko-Content-Viewers JavaScript-global-privileged-property JavaScript-global-property JavaScript-navigator-property XSLT-extension-functions addon-provider-module agent-style-sheets app-startup bookmark-observers charset-detectors command-line-handler content-policy content-sniffing-services external-uricontentlisteners healthreport-js-provider-default history-observers idle-daily module-loader net-channel-event-sinks net-content-sniffers pref-config-startup profile-after-change update-timer vacuum-participant webapps-clear-data xpcom-directory-providers ********************************** app-startup entries: ********************************** ContentProcessSingleton PushNotificationService Script Security Manager TelemetryStartup Window Data Source ********************************** So manifest config and category manager appear to be configured right, but the module does not receive any app-startup observers. This also likely breaks ContentProcessSingleton.
tracking-e10s:
--- → ?
Assignee | ||
Comment 4•9 years ago
|
||
> manifest config and category manager appear to be configured right, but
> the module does not receive any app-startup observers. This also likely
> breaks ContentProcessSingleton.
Turns out ContentProcessSingleton loads fine, TelemetryStartup does not.
Updated•9 years ago
|
Assignee | ||
Comment 5•9 years ago
|
||
Ok, here's what's happening: 1) TelemetryStartup.js sources TelemetryEnvironment.jsm 2) TelemetryEnvironment.jsm sources AddonManager.jsm 3) AddonManager.jsm load errors out here - http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#12 This breaks the app-startup init of telemetry in the content process. Since we don't use TelemetryEnvironment in the child here, I just switched it to a lazy getter.
Attachment #8614294 -
Flags: review?(dtownsend)
Comment 6•9 years ago
|
||
Comment on attachment 8614294 [details] [diff] [review] patch v.1 Review of attachment 8614294 [details] [diff] [review]: ----------------------------------------------------------------- Stealing review. As i'm working actively right now on Telemetry modifications, feel free to CC me on similar bugs.
Attachment #8614294 -
Flags: review?(dtownsend) → review+
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d0d7cc5740
Assignee | ||
Comment 8•9 years ago
|
||
- updated commit
Attachment #8614294 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6fa1823420a8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•