Closed Bug 1169473 Opened 5 years ago Closed 4 years ago

Re-add MP4 telemetry

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox41 --- affected
firefox42 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

Bug 1136877 added MP4/H264 telemetry, but there isn't any support telemetry in MediaFormatReader so that functionality has been lost.

It should be re-added, this should be added in the MP4Demuxer class.
Attachment #8633940 - Flags: review?(miket)
Assignee: nobody → jyavenard
Comment on attachment 8633940 [details] [diff] [review]
Re-add H264 telemetry.

Review of attachment 8633940 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks for porting this over. :)

::: dom/media/fmp4/MP4Demuxer.cpp
@@ +219,5 @@
> +      mFoundSPSForTelemetry =
> +        AccumulateSPSTelemetry(mInfo->GetAsVideoInfo()->mExtraData);
> +    } else {
> +      // No SPS to be found.
> +      mFoundSPSForTelemetry = true;

Looks a little funny to set this to true when SPS is not found, but I see why.
Attachment #8633940 - Flags: review?(miket) → review+
I'll rename the variable, something like mSearchSPSForTelemetry
https://hg.mozilla.org/mozilla-central/rev/629be6181824
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.