Closed
Bug 1169473
Opened 11 years ago
Closed 11 years ago
Re-add MP4 telemetry
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla42
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(1 file)
|
8.03 KB,
patch
|
miketaylr
:
review+
|
Details | Diff | Splinter Review |
Bug 1136877 added MP4/H264 telemetry, but there isn't any support telemetry in MediaFormatReader so that functionality has been lost.
It should be re-added, this should be added in the MP4Demuxer class.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8633940 -
Flags: review?(miket)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jyavenard
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8633940 [details] [diff] [review]
Re-add H264 telemetry.
Review of attachment 8633940 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Thanks for porting this over. :)
::: dom/media/fmp4/MP4Demuxer.cpp
@@ +219,5 @@
> + mFoundSPSForTelemetry =
> + AccumulateSPSTelemetry(mInfo->GetAsVideoInfo()->mExtraData);
> + } else {
> + // No SPS to be found.
> + mFoundSPSForTelemetry = true;
Looks a little funny to set this to true when SPS is not found, but I see why.
Attachment #8633940 -
Flags: review?(miket) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
I'll rename the variable, something like mSearchSPSForTelemetry
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•