1169479 - 500 error when attaching patch with r? but no reviewer

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Chris AtLee [:catlee]]

I was just trying to attach a patch to https://bugzilla.mozilla.org/show_bug.cgi?id=1168999 and set it to r? without a reviewer set, but was getting 500 errors back consistently. If I set a reviewer, then I was able to successfully attach the patch.

stephend points out this is likely this error:
https://errormill.mozilla.org/bugzilla/bmo/group/397961/

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Here's the stacktrace:

at /data/www/bugzilla.mozilla.org/extensions/Review/Extension.pm line 614
	Bugzilla::Extension::Review::flag_end_of_update(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Hook.pm line 33
	Bugzilla::Hook::process(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Flag.pm line 564
	Bugzilla::Flag::update_flags(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Attachment.pm line 914
	Bugzilla::Attachment::update(...) called at /data/www/bugzilla.mozilla.org/attachment.cgi line 614
	ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::data_www_bugzilla_2emozilla_2eorg_attachment_2ecgi::insert(...) called at /data/www/bugzilla.mozilla.org/attachment.cgi line 124
	ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::data_www_bugzilla_2emozilla_2eorg_attachment_2ecgi::handler(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 204
	eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 204
	ModPerl::RegistryCooker::run(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 170
	ModPerl::RegistryCooker::default_handler(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 31
	ModPerl::Registry::handler(...) called at /data/www/bugzilla.mozilla.org/mod_perl.pl line 143
	Bugzilla::ModPerl::ResponseHandler::handler(...) called at -e line 0
	eval {...} called at -e line 0

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Looks like bug 751862 broke requests-to-the-wind. https://github.com/mozilla/webtools-bmo-bugzilla/commit/3afcaf37c3b679c68c6f0610bd861cb80722733d#diff-ef2db567549b78dfde7d026f9759ca15R613 

Checking if there's a reviewer_obj first will fix this.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1169479_1.patch

Fixed error, and I think it reads better this way.

Comment 4

[:glob ✱]

Comment on attachment 8612938 [details] [diff] [review]
1169479_1.patch

Review of attachment 8612938 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 5

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   ec53674..587b71d  master -> master