Closed
Bug 1169479
Opened 9 years ago
Closed 9 years ago
500 error when attaching patch with r? but no reviewer
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: dylan)
References
Details
Attachments
(1 file)
1.29 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
I was just trying to attach a patch to https://bugzilla.mozilla.org/show_bug.cgi?id=1168999 and set it to r? without a reviewer set, but was getting 500 errors back consistently. If I set a reviewer, then I was able to successfully attach the patch. stephend points out this is likely this error: https://errormill.mozilla.org/bugzilla/bmo/group/397961/
Here's the stacktrace: at /data/www/bugzilla.mozilla.org/extensions/Review/Extension.pm line 614 Bugzilla::Extension::Review::flag_end_of_update(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Hook.pm line 33 Bugzilla::Hook::process(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Flag.pm line 564 Bugzilla::Flag::update_flags(...) called at /data/www/bugzilla.mozilla.org/Bugzilla/Attachment.pm line 914 Bugzilla::Attachment::update(...) called at /data/www/bugzilla.mozilla.org/attachment.cgi line 614 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::data_www_bugzilla_2emozilla_2eorg_attachment_2ecgi::insert(...) called at /data/www/bugzilla.mozilla.org/attachment.cgi line 124 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::data_www_bugzilla_2emozilla_2eorg_attachment_2ecgi::handler(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 204 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 204 ModPerl::RegistryCooker::run(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 170 ModPerl::RegistryCooker::default_handler(...) called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 31 ModPerl::Registry::handler(...) called at /data/www/bugzilla.mozilla.org/mod_perl.pl line 143 Bugzilla::ModPerl::ResponseHandler::handler(...) called at -e line 0 eval {...} called at -e line 0
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dylan
Assignee | ||
Comment 2•9 years ago
|
||
Looks like bug 751862 broke requests-to-the-wind. https://github.com/mozilla/webtools-bmo-bugzilla/commit/3afcaf37c3b679c68c6f0610bd861cb80722733d#diff-ef2db567549b78dfde7d026f9759ca15R613 Checking if there's a reviewer_obj first will fix this.
Status: NEW → ASSIGNED
See Also: → 751862
Assignee | ||
Comment 3•9 years ago
|
||
Fixed error, and I think it reads better this way.
Attachment #8612938 -
Flags: review?(glob)
Comment on attachment 8612938 [details] [diff] [review] 1169479_1.patch Review of attachment 8612938 [details] [diff] [review]: ----------------------------------------------------------------- r=glob
Attachment #8612938 -
Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git ec53674..587b71d master -> master
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Extensions: Review → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•