1169514 - maintain the preference style sheet in the style sheet cache

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

There's no need for each pres shell to create its own preference style sheet.  We should just have a single style sheet that's maintained by the nsLayoutStylesheetCache.  This will help us cache more rule processors in bug 77999, too.

Comment 1

[Cameron McCormack (:heycam)]

While most of the rules inserted into the preference style sheet are just based on preference values, there are a couple that aren't.  The rule added in nsPresShell::SetPrefNoScriptRule is based on the document's "is script enabled" flag, and the rules added in nsPresShell::SetPrefNoFramesRule are based on whether the doc shell's GetAllowSubframes return value.  These might be better handled as media queries, like we'll do for the quirks mode rules in bug 1169512.

Comment 2

[Cameron McCormack (:heycam)]

Or separate style sheets that we add to the style set.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Part 1: Move noscript rule from the preference style sheet to a cached UA style sheet.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Part 2: Move noframes rules from the preferences style sheet to a cached UA style sheet.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: Part 3: Use a shared preference style sheet across all pres contexts.

Comment 6

[Cameron McCormack (:heycam)]

Attachment: Part 3: Use a shared preference style sheet across all pres contexts.

Forgot to rev nsIPresShell's IID.

Comment 7

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=49f8b3b9b044 (this has all three patches applied)

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44e4a6479eb1
https://hg.mozilla.org/integration/mozilla-inbound/rev/fca18f7bf521
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f69f20370b7

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44e4a6479eb1
https://hg.mozilla.org/mozilla-central/rev/fca18f7bf521
https://hg.mozilla.org/mozilla-central/rev/8f69f20370b7