Closed Bug 1169514 Opened 8 years ago Closed 8 years ago

maintain the preference style sheet in the style sheet cache

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(3 files, 1 obsolete file)

There's no need for each pres shell to create its own preference style sheet.  We should just have a single style sheet that's maintained by the nsLayoutStylesheetCache.  This will help us cache more rule processors in bug 77999, too.
While most of the rules inserted into the preference style sheet are just based on preference values, there are a couple that aren't.  The rule added in nsPresShell::SetPrefNoScriptRule is based on the document's "is script enabled" flag, and the rules added in nsPresShell::SetPrefNoFramesRule are based on whether the doc shell's GetAllowSubframes return value.  These might be better handled as media queries, like we'll do for the quirks mode rules in bug 1169512.
Or separate style sheets that we add to the style set.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8613390 - Flags: review?(jwatt)
Forgot to rev nsIPresShell's IID.
Attachment #8613392 - Attachment is obsolete: true
Attachment #8613392 - Flags: review?(jwatt)
Attachment #8613393 - Flags: review?(jwatt)
Attachment #8613390 - Flags: review?(jwatt) → review+
Attachment #8613391 - Flags: review?(jwatt) → review+
Attachment #8613393 - Flags: review?(jwatt) → review+
Depends on: 1194856
Depends on: 1234758
You need to log in before you can comment on or make changes to this bug.