1169656 - Deploy Mercurial 3.4.1

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

Mercurial 3.4.1 should be released in a few days. Per our upgrade policy, we're allowed to upgrade hg.mozilla.org to the first point release after a quarterly release.

3.4 contains some notable improvements that we want on the server:

* better tags cache (should make performance issues with some operations such as cancelling pushes to try go away)
* JSON style on hgweb
* Support for bundle2
* Fixes for performance regression in blame

The added json style may conflict with our pushlog extension, as it also adds a json handler to the web app. That is the only compatibility concern I can think of. Otherwise, this should be a relatively easy deployment.

Comment 1

[Gregory Szorc [:gps]]

Instead of dealing with json foo before we roll out server changes, let's defer incorporating upstream's json style until after 3.4.1 is deployed to hg.mozilla.org. That way, in case something goes wrong with the 3.4.1 deployment, we don't have to worry about json/pushlog foo during the rollback.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: ansible: upgrade to Mercurial 3.4.1 (bug 1169656); r?bkero

ansible: upgrade to Mercurial 3.4.1 (bug 1169656); r?bkero

Upgrade all references to Mercurial to 3.4.1 (from 3.3.{2,3}).

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hgtemplates: synchronize with Mercurial 3.4.1 (bug 1169656); r?bkero

hgtemplates: synchronize with Mercurial 3.4.1 (bug 1169656); r?bkero

A copy of Mercurial's templates directory was overlayed onto
hgtemplates after the contents of hgtemplates/ were locally deleted. The
gitweb_mozilla and gitweb_mozilla_pvt themes were manually restored, as
were some one-off files required by it. Some upstream-removed files have
been deleted from version control.

The added json style has not been included because it almost certainly
conflicts with pushlog's json code. We'll modify pushlog later, once
3.4.1 is safely deployed to production.

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: hgtemplates: merge gitweb style changes to gitweb_mozilla (bug 1169656); r?bkero

hgtemplates: merge gitweb style changes to gitweb_mozilla (bug 1169656); r?bkero

There were minor changes made to the gitweb style in Mercurial 3.4.
Apply them to gitweb_mozilla so it stays in sync with upstream.

Comment 5

[Ben Kero [:bkero]]

Comment on attachment 8614913 [details]
MozReview Request: ansible: upgrade to Mercurial 3.4.1 (bug 1169656); r?bkero

https://reviewboard.mozilla.org/r/10119/#review8891

Ship It!

Comment 6

[Gregory Szorc [:gps]]

Before we actively start serving with 3.4.1, we'll want to manually generate tags data for repos with many heads (try, beta, release) to pre-seed the new .hgtags fnodes cache. If we don't do this, the first request to look up tags data will trigger a potentially expensive computation of the .hgtags fnodes values and long pauses could occur. This runs the risk of causing some operations to time out or possibly even a CPU flood if the conditions are right.

Realistically, try is the only repo we care about here, as it has a magnitude more heads than any other repo.

Comment 7

[Ben Kero [:bkero]]

Comment on attachment 8614915 [details]
MozReview Request: hgtemplates: merge gitweb style changes to gitweb_mozilla (bug 1169656); r?bkero

https://reviewboard.mozilla.org/r/10123/#review8893

Ship It!

Comment 8

[Ben Kero [:bkero]]

Comment on attachment 8614914 [details]
MozReview Request: hgtemplates: synchronize with Mercurial 3.4.1 (bug 1169656); r?bkero

https://reviewboard.mozilla.org/r/10121/#review8895

Ship It!

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/8dbd331c5a37
https://hg.mozilla.org/hgcustom/version-control-tools/rev/db47f71dbc15
https://hg.mozilla.org/hgcustom/version-control-tools/rev/8e8e4b728130

Comment 10

[Gregory Szorc [:gps]]

Mercurial 3.4.1 is now deployed to hg.mozilla.org and reviewboard-hg.mozilla.org.