1169665 - enumerateDevices should never fail with NotFoundError

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

On systems with neither microphones nor cameras, navigator.mediaDevices.enumerateDevices() fails with NotFoundError.

From https://travis-ci.org/webrtc/adapter/jobs/64569540 :
> not ok 16 enumerateDevices() must succeed - NotFoundError: The object can not be found here.

The spec says it should return an empty array in this case, so this is a spec violation.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup

Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=483292725214

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

https://reviewboard.mozilla.org/r/9767/#review8585

I want to say r+, but mozreview won't let me. :-(

::: dom/media/MediaManager.cpp:367
(Diff revision 1)
> +      if (mPrivileged) {

If we have to explain that "privileged" actually means X, then let's rename it.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

https://reviewboard.mozilla.org/r/9767/#review8615

"Ship it!" == r+.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8613680 [details]
MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup

Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8613680 [details]
MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup

https://reviewboard.mozilla.org/r/9769/#review8617

Ship It!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7730f834fa30

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7730f834fa30