enumerateDevices should never fail with NotFoundError

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jib, Assigned: jib)

Tracking

39 Branch
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

On systems with neither microphones nor cameras, navigator.mediaDevices.enumerateDevices() fails with NotFoundError.

From https://travis-ci.org/webrtc/adapter/jobs/64569540 :
> not ok 16 enumerateDevices() must succeed - NotFoundError: The object can not be found here.

The spec says it should return an empty array in this case, so this is a spec violation.
Created attachment 8613680 [details]
MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup

Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail
Attachment #8613680 - Flags: review?(rjesup)
Assignee: nobody → jib
https://reviewboard.mozilla.org/r/9767/#review8585

I want to say r+, but mozreview won't let me. :-(

::: dom/media/MediaManager.cpp:367
(Diff revision 1)
> +      if (mPrivileged) {

If we have to explain that "privileged" actually means X, then let's rename it.

Updated

3 years ago
Attachment #8613680 - Flags: review?(rjesup) → review+
Comment on attachment 8613680 [details]
MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup

Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup
Attachment #8613680 - Attachment description: MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail → MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup
Attachment #8613680 - Flags: review+
Attachment #8613680 - Flags: review+
Comment on attachment 8613680 [details]
MozReview Request: Bug 1169665 - have enumerateDevices return empty array on zero devices instead of fail. r=jesup

https://reviewboard.mozilla.org/r/9769/#review8617

Ship It!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7730f834fa30
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.