1169758 - Reloading repo doesn't work after filtering repo by author + get|next N

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Jonathan French (:jfrench)]

With the recent get next N changes (fromchange, tochange) in bug 1078209 pushed to stage, I can reproduce one scenario where the Repo doesn't reload when it should.

To reproduce:
o load m-i and filter by author, eg.
https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&author=[e-mail]
o scroll to the bottom and click on get|next 10 *twice
o nb. ...there aren't any more resultsets with that author name anyway
o click on the mozilla-inbound repo button at the top navbar to reload m-i

Expected:
All m-i pushes reload, with no filter.

Observed:
Nothing happens.

Comment 1

[Cameron Dawson [:camd]]

I think that has something to do with the "skipNextReload" param.  It's not getting set back to false if there are no more items to load.

Comment 2

[Cameron Dawson [:camd]]

Attachment: PR

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8614327 [details] [review]
PR

r+, with the indentation fix :-)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/25baf8d2b3668d461a1efa1b871611b84ee89057
Bug 1169758 - reload repo after author filter + get next N