1169810 - Logviewer could look better in URL bar

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[William Lachance (:wlach)]

There's a few things that are silly about the logviewer as it stands right now:

1. It has a redundant "logviewer -" in the title (the title should reflect the content).
2. The favicon is a tree, even though it has nothing to do with the tree.

Fixing these is easy, so I'm just going to do it.

Comment 1

[William Lachance (:wlach)]

Attachment: PR

Comment 2

[Jonathan French (:jfrench)]

Comment on attachment 8613102 [details] [review]
PR

Looks nice! I tested the branch locally also. On tab hover we now just see the buildername as the document title but the new 'Log' icon will always be present in the tab whether or not the tab is pinned, so the user sees that.

I do wonder for visually impaired though, since the screen reader will announce the page as "[buildername]" instead of "Log viewer - [buildername]". Maybe we could have both the icon and the "Log viewer -".

Treeherder itself suffers from that in a way though, as it just has the unclassified failure count and repo as the document title.

A nice improvement though so r+.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0646651f515ad66a08ad96775dde984f346f3dfc
Bug 1169810 - Tweak way logviewer looks in URL bar

Comment 4

[William Lachance (:wlach)]

After chatting about it in accessibility, it does sound like the title is useful so I adjusted it to "Log for Foo Bar Baz" before pushing.