Closed Bug 1169823 Opened 8 years ago Closed 8 years ago

Update test_safe_browsing_notification test for new "unwanted software" feature

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: mwobensmith, Assigned: mwobensmith)

References

Details

Attachments

(1 file)

github_pull_request.txt
52 bytes, text/x-github-pull-request
whimboo
: review+
whimboo
: feedback+
Details | Review 
      No description provided.
Comment on attachment 8613129 [details] [review]
github_pull_request.txt

Matt, if you want a review/feedback for a Firefox UI test you should primarily request it from me. I assume the PR is ready for at least a feedback round? I will check that later today.
Attachment #8613129 - Flags: feedback?(hskupin)
Test is currently failing in test suite, still investigating. When I'm able to fix it, I'll request a formal review.
OK, test passes now and is ready for your review.
Flags: needinfo?(hskupin)
Comment on attachment 8613129 [details] [review]
github_pull_request.txt

f+. I made some comments on the PR which I would to be addressed.
Flags: needinfo?(hskupin)
Attachment #8613129 - Flags: feedback?(hskupin) → feedback+
Comment on attachment 8613129 [details] [review]
github_pull_request.txt

Latest commit fixes all my concerns. I will go ahead and merge it in a moment. Thanks Matt!
Attachment #8613129 - Flags: review+
Merged to master for Firefox 41.0:
https://github.com/mozilla/firefox-ui-tests/commit/5e50fbf3e2bd2e6a3728dee5a1cdb43b77ef04ee

Matt, would a backport be needed or is that non-critical?
status-firefox41: --- → fixed
Flags: needinfo?(mwobensmith)
Target Milestone: --- → Firefox 41
I don't think this is critical.
Flags: needinfo?(mwobensmith)
Ok, then we are not going to backport it. Thanks Matt!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.