1169823 - Update test_safe_browsing_notification test for new "unwanted software" feature

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Comment 1

[Matt Wobensmith [:mwobensmith][:matt:]]

Attachment: github_pull_request.txt

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8613129 [details] [review]
github_pull_request.txt

Matt, if you want a review/feedback for a Firefox UI test you should primarily request it from me. I assume the PR is ready for at least a feedback round? I will check that later today.

Comment 3

[Matt Wobensmith [:mwobensmith][:matt:]]

Test is currently failing in test suite, still investigating. When I'm able to fix it, I'll request a formal review.

Comment 4

[Matt Wobensmith [:mwobensmith][:matt:]]

OK, test passes now and is ready for your review.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8613129 [details] [review]
github_pull_request.txt

f+. I made some comments on the PR which I would to be addressed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8613129 [details] [review]
github_pull_request.txt

Latest commit fixes all my concerns. I will go ahead and merge it in a moment. Thanks Matt!

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Merged to master for Firefox 41.0:
https://github.com/mozilla/firefox-ui-tests/commit/5e50fbf3e2bd2e6a3728dee5a1cdb43b77ef04ee

Matt, would a backport be needed or is that non-critical?

Comment 8

[Matt Wobensmith [:mwobensmith][:matt:]]

I don't think this is critical.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, then we are not going to backport it. Thanks Matt!