1169853 - export default AssignmentExpression without trailing semicolon wrongly passes parser.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

Reflect.parse("export default a 1")

Returns valid Program, since semicolon after AssignmentExpression is not checked.

http://people.mozilla.org/~jorendorff/es6-draft.html#sec-exports
> ExportDeclaration :
>   ...
>   export default [lookahead ∉ {function, class}] AssignmentExpression[In] ;

https://dxr.mozilla.org/mozilla-central/source/js/src/frontend/Parser.cpp#4520
>          default:
>            tokenStream.ungetToken();
>            kid = assignExpr(InAllowed, YieldIsKeyword);
>            break;

MatchOrInsertSemicolon should be there.

Comment 1

[Tooru Fujisawa [:arai]]

Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8475878269b

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Require semicolon after export default AssignmentExpression.

Added MatchOrInsertSemicolon after assingExpr for `export default`.

Comment 3

[Jon Coppeard (:jonco)]

Thanks for fixing this arai.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae084da24b51

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae084da24b51