1169881 - Recompute image visibility when display port margins change

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Seth Fowler [:seth] [:s2h]]

During scrolling, display port margins can go through large changes. A fast fling can produce a display port that's 10,000 CSS pixels high or more! Those huge display ports do get shrunk back down once scrolling stops or slows down, but we currently don't have any way of updating image visibility information when that happens.

Let's add code to update image visibility information when display port margins change.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Recompute image visibility when display port margins change

Here's the patch. So easy!

Comment 2

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=22334b8e2a76

Comment 3

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a609d5e44a3

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7a609d5e44a3

Comment 5

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8613201 [details] [diff] [review]
Recompute image visibility when display port margins change

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Not sure, but it was exposed by the fact that we enabled image locking on B2G in bug 1148696.
User impact if declined: Images may fail to decode due to low memory, causing blank thumbnails in the gallery which may persist across reboots (making this effectively a data loss issue). This patch is one of several that together fix bug 1166136, which is nominated for blocking 2.2, and bug 1164164, which is a 2.2 blocker.
Testing completed: Extensively tested locally. On mozilla-central.
Risk to taking this patch (and alternatives if risky): This is a very simple, low risk patch.
String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5b3f1796ddf6