1169915 - Make flake8 check .pyx files too

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Currently it only checks *.py (same as pep8):
http://flake8.readthedocs.org/en/latest/config.html#settings

...so missed the Cython files we have under treeherder/log_parser/

Comment 1

[Ed Morley [:emorley]]

Attachment: Make flake8 check .pyx files too

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f279c5f9ad9a7b372bb146ac46b1d6b8f26f8946
Bug 1169915 - Fix flake8 warnings in .pyx files

Until now we were not checking pyx files and so didn't see these.

artifactbuildercollection.pyx:125:51: E261 at least two spaces before inline comment
artifactbuilders.pyx:19:1: E302 expected 2 blank lines, found 1
artifactbuilders.pyx:99:1: E302 expected 2 blank lines, found 1
artifactbuilders.pyx:110:1: E302 expected 2 blank lines, found 1
artifactbuilders.pyx:126:21: E128 continuation line under-indented for visual indent
artifactbuilders.pyx:127:21: E128 continuation line under-indented for visual indent
artifactbuilders.pyx:128:21: E128 continuation line under-indented for visual indent
artifactbuilders.pyx:134:9: E303 too many blank lines (2)
artifactbuilders.pyx:154:5: E303 too many blank lines (2)
parsers.pyx:173:12: E713 test for membership should be 'not in'

https://github.com/mozilla/treeherder/commit/acbc0b6d362880e2a3dbae7ae2ffda0d1ce33bd4
Bug 1169915 - flake8/pep8: Check *.pyx files too

flake8/pep8 default to just checking *.py, but we have Cython .pyx files
in treeherder/log_parser/.

Comment 3

[Ed Morley [:emorley]]

Thanks for the review :-)