1169944 - Enable the newrelic wrapper everywhere and not just in production

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

For things like bug 1124278, we're going to want to sprinkle new relic annotations around the codebase. We'd have to make these all conditional on the New Relic package being installed, or else wrap it with something we can stub out locally.

If we instead moved the newrelic package to common.txt, we would (a) avoid having to do this, (b) actually test/develop on something closer to what's running in production, (c) be able to make the scripts in bin/ fail if newrelic-admin isn't installed (right now they'll silently carry on), (d) be able to ditch prod.txt entirely.

All we'll need to do is make sure that New Relic doesn't have the key locally & ensure it doesn't error out without the key.

Comment 1

[Ed Morley [:emorley]]

Attachment: Always install the New Relic package, not just on prod

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ae89891150bff086aa8f882520a5e05908105838
Bug 1169944 - Cleanup imports in wsgi.py

This file was excluded from the isort run, since the import order must
be preserved. However there are a few things we can still clean up.

https://github.com/mozilla/treeherder/commit/f9ee81d999789aa31c81d1193fd393e11629fc69
Bug 1169944 - Always install the New Relic package, not just on prod

For bug 1124278, we're going to want to sprinkle new relic annotations
around the codebase, so by always installing it, we save having to stub
these out in development/on Travis. It also seems wise to have prod
running as close to the same packages as in development.

Since NEW_RELIC_LICENSE_KEY isn't set locally, plus
NEW_RELIC_DEVELOPER_MODE is set to true, the New Relic agent doesn't
submit anything. See:
https://docs.newrelic.com/docs/agents/python-agent/installation-configuration/python-agent-configuration#developer_mode

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/392af575dc9bfba4000457b905a2cc919ea97b26
Bug 1169944 - Remove requirements/prod.txt since it contains no packages

We had to do at least one deploy after the initial landing of
bug 1169944, before removing prod.txt, to avoid errors during update.py.
That has now occurred, so we can remove the file.

Comment 4

[Ed Morley [:emorley]]

Switching to using the wrapper in the second landing in bug 1191080 partially regressed this - newrelic-admin is only used when NEW_RELIC_LICENSE_KEY is set, which is not the case in the vagrant environment. 

We can just remove the conditional on that, eg:
https://github.com/mozilla/treeherder/search?q=NEW_RELIC_LICENSE_KEY

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:newrelic-locally > mozilla:master

Comment 6

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:newrelic-locally > mozilla:master

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/519bf901ad13e2ce8b9d9cba05f1f3e23ce93714
Bug 1169944 - Use the New Relic wrapper when running scripts locally too

Previously if the `bin/` directory scripts were run in the Vagrant
environment, the processes run would not have been started via the
New Relic wrapper command, since the New Relic licence key is not set.

For greater consistency between Vagrant and production, the wrapper
command is now always used.

This works since `NEW_RELIC_DEVELOPER_MODE` is defined in the Vagrant
environment (thanks to a previous commit in the same bug), which
prevents the agent from trying to submit real data:
https://docs.newrelic.com/docs/agents/python-agent/installation-configuration/python-agent-configuration#developer_mode