1169981 - listitem and treechildren have a radius and are no more flat after bug 1166867

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Richard Marti (:Paenglab)]

After bug 1166867 the listitems and treechildrens are using the win7 styling instead of the win8 styling.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: noRadius.patch

Fix by adding the media query for win10.

Comment 2

[Tim Nguyen :ntim]

(In reply to Richard Marti (:Paenglab) from comment #1)
> Created attachment 8613279 [details] [diff] [review]
> noRadius.patch
> 
> Fix by adding the media query for win10.

May be better to move out the win 8 rules from the win 8 block, then wrap the aero rules with -moz-os-version: win7/vista

Comment 3

[Richard Marti (:Paenglab)]

Attachment: noRadius-alt.patch

Okay this patch does the same but win8+ is the default and Vista/win7 has additional styles.

Dão, I let you choose which one you prefer.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/41f95395226e

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8613285 [details] [diff] [review]
noRadius-alt.patch

Approval Request Comment
[Feature/regressing bug #]: regression of bug 1166867
[User impact if declined]: users will see Windows 7 styling on Windows 10
[Describe test coverage new/current, TreeHerder]: will land on m-c
[Risks and why]: low, css only change
[String/UUID change made/needed]: nope

Comment 6

[Dão Gottwald [:dao]]

This really isn't ESR material.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41f95395226e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

There's still a pending approval request for esr38 here. Please wait to set the status flags until that decision is made.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8613285 [details] [diff] [review]
noRadius-alt.patch

Approved for uplift to aurora and beta. I'd like us to verify this on beta please.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8613285 [details] [diff] [review]
noRadius-alt.patch

Windows 10 will be offered to Windows user during the 38 esr cycle. Taking it as it is low risk.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ed62f1d19c12

Comment 12

[Ryan VanderMeulen [:RyanVM]]

We either need to backport bug 1150006 to 38/39 or rebase the patch in this bug. Not sure which option makes more sense.

Comment 13

[Tim Nguyen :ntim]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #12)
> We either need to backport bug 1150006 to 38/39 or rebase the patch in this
> bug. Not sure which option makes more sense.

I'm going to rebase this on top of beta.

Comment 14

[Tim Nguyen :ntim]

Attachment: Patch for beta and ESR 38

This patch was created on top of mozilla-beta, I don't know if it applies cleanly on ESR though.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c1d5e2461d4

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/5bc4a0310c5c

Comment 17

[Andrei Vaida [:avaida]]

Reproduced the bug on Nightly 41.0a1 (2015-05-31), using Windows 10 x64 (build 10130).

This is verified fixed on Nightly 41.0a1 (2015-06-17), Beta 39.0b6 (20150615125213) and ESR 38.0.1esrpre (tinderbox, 20150616140147), using Windows 10 x64 (build 10130) and Windows 8.1 x64. Used the Library and Sidebars to confirm the styling.

Comment 18

[Andrei Vaida [:avaida]]

Verified fixed on Beta 40.0b2 (20150706172413) as well, using Windows 10 Pro x64 (Build 10158) and Windows 8.1 Pro x86.