Closed Bug 1169981 Opened 4 years ago Closed 4 years ago

listitem and treechildren have a radius and are no more flat after bug 1166867

Categories

(Toolkit :: Themes, defect)

All
Windows 10
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla41
Tracking Status
firefox38 --- unaffected
firefox38.0.5 --- unaffected
firefox39 --- verified
firefox40 --- verified
firefox41 --- verified
firefox-esr38 39+ verified

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

After bug 1166867 the listitems and treechildrens are using the win7 styling instead of the win8 styling.
Attached patch noRadius.patch (obsolete) — Splinter Review
Fix by adding the media query for win10.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8613279 - Flags: review?(dao)
(In reply to Richard Marti (:Paenglab) from comment #1)
> Created attachment 8613279 [details] [diff] [review]
> noRadius.patch
> 
> Fix by adding the media query for win10.

May be better to move out the win 8 rules from the win 8 block, then wrap the aero rules with -moz-os-version: win7/vista
Okay this patch does the same but win8+ is the default and Vista/win7 has additional styles.

Dão, I let you choose which one you prefer.
Attachment #8613285 - Flags: review?(dao)
Attachment #8613285 - Flags: review?(dao) → review+
Attachment #8613279 - Flags: review?(dao)
Keywords: checkin-needed
Attachment #8613279 - Attachment is obsolete: true
Comment on attachment 8613285 [details] [diff] [review]
noRadius-alt.patch

Approval Request Comment
[Feature/regressing bug #]: regression of bug 1166867
[User impact if declined]: users will see Windows 7 styling on Windows 10
[Describe test coverage new/current, TreeHerder]: will land on m-c
[Risks and why]: low, css only change
[String/UUID change made/needed]: nope
Attachment #8613285 - Flags: approval-mozilla-esr38?
Attachment #8613285 - Flags: approval-mozilla-beta?
Attachment #8613285 - Flags: approval-mozilla-aurora?
This really isn't ESR material.
https://hg.mozilla.org/mozilla-central/rev/41f95395226e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
There's still a pending approval request for esr38 here. Please wait to set the status flags until that decision is made.
Comment on attachment 8613285 [details] [diff] [review]
noRadius-alt.patch

Approved for uplift to aurora and beta. I'd like us to verify this on beta please.
Attachment #8613285 - Flags: approval-mozilla-beta?
Attachment #8613285 - Flags: approval-mozilla-beta+
Attachment #8613285 - Flags: approval-mozilla-aurora?
Attachment #8613285 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
Comment on attachment 8613285 [details] [diff] [review]
noRadius-alt.patch

Windows 10 will be offered to Windows user during the 38 esr cycle. Taking it as it is low risk.
Attachment #8613285 - Flags: approval-mozilla-esr38? → approval-mozilla-esr38+
We either need to backport bug 1150006 to 38/39 or rebase the patch in this bug. Not sure which option makes more sense.
Flags: needinfo?(richard.marti)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #12)
> We either need to backport bug 1150006 to 38/39 or rebase the patch in this
> bug. Not sure which option makes more sense.

I'm going to rebase this on top of beta.
Flags: needinfo?(richard.marti)
Flags: needinfo?(ntim.bugs)
This patch was created on top of mozilla-beta, I don't know if it applies cleanly on ESR though.
Flags: needinfo?(ntim.bugs)
Reproduced the bug on Nightly 41.0a1 (2015-05-31), using Windows 10 x64 (build 10130).

This is verified fixed on Nightly 41.0a1 (2015-06-17), Beta 39.0b6 (20150615125213) and ESR 38.0.1esrpre (tinderbox, 20150616140147), using Windows 10 x64 (build 10130) and Windows 8.1 x64. Used the Library and Sidebars to confirm the styling.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Verified fixed on Beta 40.0b2 (20150706172413) as well, using Windows 10 Pro x64 (Build 10158) and Windows 8.1 Pro x86.
You need to log in before you can comment on or make changes to this bug.