1170030 - Enable Angular's strict dependency injection mode

Status: RESOLVED DUPLICATE of bug 1336556

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Ed Morley [:emorley]]

From https://docs.angularjs.org/guide/production :

"""
Using strict di mode in your production application will throw errors when a injectable function is not annotated explicitly. Strict di mode is intended to help you make sure that your code will work when minified. However, it also will force you to make sure that your injectable functions are explicitly annotated which will improve angular's performance when injecting dependencies in your injectable functions because it doesn't have to dynamically discover a function's dependencies. It is recommended to automate the explicit annotation via a tool like ng-annotate when you deploy to production (and enable strict di mode)
"""

We can either:
1) Enable strict DI mode everywhere, and commit these annotations to the repo (for example of what these annotations look like, see https://github.com/olov/ng-annotate/blob/master/README.md)
2) Enable strict DI mode just in production, and have ng-annotate run as part of grunt build.

Comment 1

[Ed Morley [:emorley]]

This was fixed in:
https://github.com/mozilla/treeherder/commit/de1137aeb8a61223569b9bc1f1d755451308788c