Closed
Bug 1170059
Opened 10 years ago
Closed 10 years ago
Fix -Wunreachable-code clang warnings in webrtc/signaling
Categories
(Core :: WebRTC: Networking, defect)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
5.49 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:978:9 [-Wunreachable-code-break] 'break' will never be executed
media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c:5166:9: error: 'break' will never be executed [-Wunreachable-code-break]
media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c:5172:9: error: 'break' will never be executed [-Wunreachable-code-break]
media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c:5226:9: error: 'break' will never be executed [-Wunreachable-code-break]
media/webrtc/signaling/src/sdp/sipcc/sdp_attr.c:5232:9: error: 'break' will never be executed [-Wunreachable-code-break]
media/webrtc/signaling/src/sdp/sipcc/sdp_attr_access.c:1629:13: error: 'return' will never be executed [-Wunreachable-code-return]
media/webrtc/signaling/src/sdp/sipcc/sdp_attr_access.c:1697:13: error: 'return' will never be executed [-Wunreachable-code-return]
media/webrtc/signaling/src/sdp/sipcc/sdp_attr_access.c:1802:13: error: 'return' will never be executed [-Wunreachable-code-return]
Attachment #8613345 -
Flags: review?(rjesup)
|
||
Updated•10 years ago
|
Attachment #8613345 -
Flags: review?(rjesup) → review+
|
||
Comment 2•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
Assignee | |
Updated•9 years ago
|
Blocks: Wunreachable-code
You need to log in
before you can comment on or make changes to this bug.
Description
•