Closed Bug 1170082 Opened 9 years ago Closed 9 years ago

[Stingray][TVDeck] Attach MediaStream object on video element by using mozSrcObject

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: suchiu, Assigned: suchiu)

Details

Attachments

(1 file)

[gaia] sean2449:Bug-1170082-mozSrcObject > mozilla-b2g:master
46 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review 
As title, mozSrcObject is a correct way to attach MediaStream object on video element.
Comment on attachment 8613402 [details] [review]
[gaia] sean2449:Bug-1170082-mozSrcObject > mozilla-b2g:master

1. Use mozSrcObject instead of src to assign MediaStream object to video element.
2. Remove test case because mozSrcObject must be MediaStream object, which is not able to be constructed in Gaia.
Attachment #8613402 - Flags: review?(im)
Comment on attachment 8613402 [details] [review]
[gaia] sean2449:Bug-1170082-mozSrcObject > mozilla-b2g:master

Looks good to me. This is the correct version. I thought that you used src for your mock-up object although you didn't have any mock-up file.

If possible, please test with tv simulator. Thanks.
Attachment #8613402 - Flags: review?(im) → review+
Already tested on TV Simulator.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: