Closed Bug 1170103 Opened 9 years ago Closed 6 years ago

Remove more $rootScope.$broadcast calls

Categories

(Tree Management :: Treeherder: Frontend, defect, P3)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: emorley, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf) 

Leftovers from bug 1095141.

(In reply to Mauro Doglio [:mdoglio] from bug 1095141 comment #2)
> Reopening this to remove a couple of $rootScope.$broadcast calls here:
> https://github.com/mozilla/treeherder-ui/blob/new-structured-log-viewer/
> webapp/app/js/controllers/main.js#L93-L104
> and their $scope.$on counterpart here:
> https://github.com/mozilla/treeherder-ui/blob/
> 1d81a9ceb67518688711de30e7d5e4326896c59e/webapp/app/js/directives/main.js#L24
> 
> They can be safely replaced with a $rootScope.$emit() and $rootScope.$on()
Priority: P2 → P3
Component: Treeherder → Treeherder: Frontend
Wontfix since we're just going to move away from AngularJS entirely (bug 1409103).
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.