1170115 - listen to clear-origin-data in PushService

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 1168300 we will add "webapps-clear-cookiejar-data" notification, so PushService should listen to this event instead of listening "webapps-clear-data"

Comment 1

[Botond Ballo [:botond]]

Attachment: MozReview Request: reviewboardmods: populate the 'Bugs' field in review drafts (bug 1170115). r=smacleod

reviewboardmods: populate the 'Bugs' field in review drafts (bug 1170115). r=smacleod

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8650153 [details]
MozReview Request: reviewboardmods: populate the 'Bugs' field in review drafts (bug 1170115). r=smacleod

This is a first crack. I tested it in my local test environment and it seems to be working.

I didn't remove the code that sets the bugs_closed field upon publishing; should I, or do we still need it for some edge cases where the bug isn't known at draft creation time?

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8650153 [details]
MozReview Request: reviewboardmods: populate the 'Bugs' field in review drafts (bug 1170115). r=smacleod

Er, sorry, wrong bug number :/

Comment 4

[Lina Butler (ex-Mozilla)]

Attachment: MozReview Request: Bug 1170115 - Use `clear-origin-data` to remove Push records. r?allstars.chh

Bug 1170115 - Replace `webapps-clear-data` with `clear-origin-data` in Push. r?allstars.chh

Comment 5

[Lina Butler (ex-Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5955d1926096

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8686695 [details]
MozReview Request: Bug 1170115 - Use `clear-origin-data` to remove Push records. r?allstars.chh

https://reviewboard.mozilla.org/r/25043/#review22625

::: dom/push/test/xpcshell/test_clear_origin_data.js:1
(Diff revision 1)
> +/* Any copyright is dedicated to the Public Domain.

Shouldn't this use a 'hg mv'?

::: dom/push/test/xpcshell/test_clear_origin_data.js:71
(Diff revision 1)
> +  let data = JSON.stringify({ appId: 1, inBrowser: false });

nit, 'inBrowser: false' could be removed.

::: dom/push/test/xpcshell/test_clear_origin_data.js:83
(Diff revision 1)
> +  ok(registration, 'Registration for { 1, true } should still exist.');

when we clear registration for {appId : 1}
we should clear all registrations with appId :1,
for example,
{app:1. inBrowser: true}, {app:1. inBrowser: false} should be removed.

That's the idea of ChromeUtils.originAttributesMatchPattern

::: dom/push/test/xpcshell/xpcshell.ini:41
(Diff revision 1)
> -[test_webapps_cleardata.js]
> +[test_clear_origin_data.js]

nit,
should list alphabetically.

Comment 7

[Lina Butler (ex-Mozilla)]

https://reviewboard.mozilla.org/r/25043/#review22625

> when we clear registration for {appId : 1}
> we should clear all registrations with appId :1,
> for example,
> {app:1. inBrowser: true}, {app:1. inBrowser: false} should be removed.
> 
> That's the idea of ChromeUtils.originAttributesMatchPattern

Thanks, Yoshi! I'll add a few more test cases for different patterns, but `ChromeUtils.originAttributesMatchPattern({ appId: 1, inBrowser: true }, { appId: 1, inBrowser: false }) === false`. (Though `ChromeUtils.originAttributesMatchPattern({ appId: 1, inBrowser: true }, { appId: 1 }) === true`).

Comment 8

[Lina Butler (ex-Mozilla)]

Comment on attachment 8686695 [details]
MozReview Request: Bug 1170115 - Use `clear-origin-data` to remove Push records. r?allstars.chh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25043/diff/1-2/

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8686695 [details]
MozReview Request: Bug 1170115 - Use `clear-origin-data` to remove Push records. r?allstars.chh

https://reviewboard.mozilla.org/r/25043/#review22827

Thanks

::: dom/push/test/xpcshell/test_clear_origin_data.js:16
(Diff revision 2)
> +    let attributesString = ChromeUtils.originAttributesToSuffix(

usually we call this 'suffix' or 'origin suffix'.

Comment 10

[Lina Butler (ex-Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a43c962a140f1f83fe7ceba5ff4e31346ecc7e82
Bug 1170115 - Use `clear-origin-data` to remove Push records. r=allstars.chh

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a43c962a140f