117013 - Text Zoom dialog is too small to contain its contents

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Matthew T (active 1999-2002)]

Build: 2001122508, Mac OS 9.1

To reproduce:
1.  Choose `View' > `Text Zoom' > `Other...'
2.  Look at the dialog.

The dialog is too small, and the `Cancel' and `OK' buttons are mostly 
invisible.

Comment 1

[Matthew T (active 1999-2002)]

Attachment: screenshot

Comment 2

[sairuh (rarely reading bugmail)]

->jag

Comment 3

[jag (Peter Annema)]

Attachment: Fix

Comment 4

[Fabian Guisset]

Comment on attachment 62883 [details] [diff] [review]
Fix

r=fabian. intrinsic sizing, that's the solution. er. ok.

Comment 5

[jag (Peter Annema)]

Intrinsic sizing, yes. When you call sizeToContent() from the load handler
there's a good chance not all of the content will have been initialized yet
(widgets unhidden from load handlers in overlays), so you end up sizing
incorrectly. When you intrinsically size (i.e. when you don't explitely specify
a window size in the xul or from js in an load handler), sizeToContent() will be
called "automatically" when all load handlers have executed.

As a rule of thumb, don't use sizeToContent() from a load handler but let
intrinsic sizing do its job instead, unless you really know what you're doing.

Comment 6

[Blake Ross]

Comment on attachment 62883 [details] [diff] [review]
Fix

sr=blake

Comment 7

[jag (Peter Annema)]

Was checked in Dec 28.

Comment 8

[sairuh (rarely reading bugmail)]

vrfy fixed using 2002.01.29.11 comm mac 9.x bits [under classic emulation]. with
both themes, the text zoom other dlg looks fine.