1170263 - Enabling resetting prefs and settings after non-root factory reset.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

In order for us to be able to switch between normal and unrestricted devtools in Gaia, we need to be able to reset appropriate settings and prefs.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1170263 patch v1

Comment 2

[Gregor Wagner [:gwagner]]

Comment on attachment 8613656 [details] [diff] [review]
1170263 patch v1

Review of attachment 8613656 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/ProcessGlobal.js
@@ +69,5 @@
> +  // TODO: Remove once bug 1125916 is fixed.
> +  Services.prefs.setBoolPref("network.disable.ipc.security", unrestricted);
> +  Services.prefs.setBoolPref("dom.webcomponents.enabled", unrestricted);
> +  settings.createLock().set("developer.menu.enabled", unrestricted, null);
> +  settings.createLock().set("devtools.unrestricted", unrestricted, null);

Please use a single lock for this.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1170263 patch v2

(In reply to Gregor Wagner [:gwagner] from comment #2)
> Comment on attachment 8613656 [details] [diff] [review]
> 1170263 patch v1
> 
> Review of attachment 8613656 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: b2g/components/ProcessGlobal.js
> @@ +69,5 @@
> > +  // TODO: Remove once bug 1125916 is fixed.
> > +  Services.prefs.setBoolPref("network.disable.ipc.security", unrestricted);
> > +  Services.prefs.setBoolPref("dom.webcomponents.enabled", unrestricted);
> > +  settings.createLock().set("developer.menu.enabled", unrestricted, null);
> > +  settings.createLock().set("devtools.unrestricted", unrestricted, null);
> 
> Please use a single lock for this.

Done

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5befdd2d1ab2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5befdd2d1ab2