Closed
Bug 1170289
Opened 9 years ago
Closed 9 years ago
Move SearchEngineBar's favicons to ImageView
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(3 files)
FaviconView does inconsistent scaling (bug 1170288) so let's work around it.
The Great Antlam says 16dp x 16dp.
Be sure to fix the default favicon handling in custom search engines too.
Assignee | ||
Comment 1•9 years ago
|
||
I don't know why I ever used FaviconView when ImageView would do - we should backout bug 1166868 because it adds a lot of unneeded complexity.
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #0)
> The Great Antlam says 16dp x 16dp.
By which I mean 24dp x 24dp, of course.
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?margaret
These patches added complexity that we're removing by implementing this bug.
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1170289 - Use ImageView in the search engine bar. r?margaret
Assignee | ||
Comment 5•9 years ago
|
||
Bug 1170289 - Set default search engine favicon to magnifying glass. r?margaret
This doesn't work for the Settings screen (bug 1170346).
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8613761 [details]
MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret
Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret
These patches added complexity that we're removing by implementing this bug.
Attachment #8613761 -
Attachment description: MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?margaret → MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret
Attachment #8613761 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8613762 [details]
MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?Margaret
Bug 1170289 - Use ImageView in the search engine bar. r?Margaret
Attachment #8613762 -
Attachment description: MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?margaret → MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?Margaret
Attachment #8613762 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8613763 [details]
MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret
Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret
This doesn't work for the Settings screen (bug 1170346).
Attachment #8613763 -
Attachment description: MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?margaret → MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret
Attachment #8613763 -
Flags: review?(margaret.leibovic)
Updated•9 years ago
|
Attachment #8613761 -
Flags: review?(margaret.leibovic) → review+
Comment 9•9 years ago
|
||
Comment on attachment 8613761 [details]
MozReview Request: Bug 1170289 - Backout Bug 1166868 (changeset b73de443b580 & fefa03e0fb9d). r?Margaret
https://reviewboard.mozilla.org/r/9789/#review8737
Ship It!
Updated•9 years ago
|
Attachment #8613762 -
Flags: review?(margaret.leibovic) → review+
Comment 10•9 years ago
|
||
Comment on attachment 8613762 [details]
MozReview Request: Bug 1170289 - Use ImageView in the search engine bar. r?Margaret
https://reviewboard.mozilla.org/r/9791/#review8739
Sweet, that's simple :)
Updated•9 years ago
|
Attachment #8613763 -
Flags: review?(margaret.leibovic) → review+
Comment 11•9 years ago
|
||
Comment on attachment 8613763 [details]
MozReview Request: Bug 1170289 - Set default search engine favicon to magnifying glass. r?Margaret
https://reviewboard.mozilla.org/r/9793/#review8741
Ship It!
Assignee | ||
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/59d01945f35a
https://hg.mozilla.org/mozilla-central/rev/822ce15d8b92
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•