Closed Bug 1170296 Opened 9 years ago Closed 9 years ago

GCF test case failure: HOLD button stops responding if hold fails for a conference call


(Firefox OS Graveyard :: RIL, defect)

Gonk (Firefox OS)
Not set


(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master unaffected)

2.2 S14 (12june)
blocking-b2g 2.2+
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- unaffected


(Reporter: pgravel, Assigned: bhsu)



(Whiteboard: [caf priority: p2][CR 846400])


(1 file)

This is very similar to bug 1160325, which was fixed with bug 1161403, but that fix only resolved the single-call case.

Steps to reproduce:
* Have a conference call up
* Try to hold the conference call and have the network reject the hold request
* Now hold button is no longer responsive

One observable difference between the single-call and the conference call case is that with the latter isn't a promise.
blocking-b2g: --- → 2.2?
Whiteboard: [CR 846400] → [caf priority: p2][CR 846400]
Hsin-Yi, can your team take a look at this one?
Flags: needinfo?(htsai)
Ben, please help this, thanks!
Flags: needinfo?(htsai) → needinfo?(bhsu)
Comms triage: Certification blocker.
Blocks: 977588
blocking-b2g: 2.2? → 2.2+
Hi Hsinyi and Phil,

After reproducing this isuue on the emulator, I think the root cause might be the way we determine whether a |conferenceGroup| is active, which makes the dialer send wrong requests after failing to hold the call. Here is a more wordy explaination, after recieving and processing a hold request, the internal state of the |conferenceGroup| becomes |holding| and be taken as inactive, and then when we press the |hold button| on the dialer, according to the inactiveness, it sends out a resume request insteads of a hold request, which makes |hold button| not work as we expected.
Flags: needinfo?(bhsu)
Hi Phil,

Since I can only try this patch on the emulator, I'm not sure whether the patch works for you. Can you try this patch out first? I'll request a review for it once recieving your confirmation. Thanks.
Assignee: nobody → bhsu
Flags: needinfo?(pgravel)
Component: Gaia::Dialer → RIL
Comment on attachment 8614491 [details] [diff] [review]
Take |holding| as one of the active states

Hi Aknow,

The details are described in comment 5. Can you review this patch?
Attachment #8614491 - Flags: review?(szchen)
Attachment #8614491 - Flags: review?(szchen) → review+
Thanks, that seems to do the trick.
Flags: needinfo?(pgravel)
Comment on attachment 8614491 [details] [diff] [review]
Take |holding| as one of the active states

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 1170296
User impact if declined: 
Once we fail to hold a conference call, we can no longer hold the conference call.

Testing completed:
Functionality is manually tested with emulator,
and regression is automatically tested with try-server.

Risk to taking this patch (and alternatives if risky): NA
String or UUID changes made by this patch: NA
Attachment #8614491 - Flags: approval-mozilla-b2g37?
Hi Ben,
Thanks for the help.
I am waiting for master landed before 2.2 approval.
Flags: needinfo?(bhsu)
Hi Josh,

Sorry for such a late response and not making things clear. In fact, the |holding| state is entirely deprecated in mozilla-central since  bug 1131403, so we cannot land this patch to mozilla-central. In other words, this patch is dedicated to branch 2.2.
Flags: needinfo?(bhsu)
Comment on attachment 8614491 [details] [diff] [review]
Take |holding| as one of the active states

Thanks Ben!
Attachment #8614491 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.