1170301 - Provide more discoverable contextual information on how we determined there was a regression/improvement

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P3)

Description

[William Lachance (:wlach)]

Currently we highlight something in orange if we think there's a regression but are not sure:

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=6a3982c14382&newProject=try&newRevision=6ada351bdafc&originalSignature=b1490f9999855ac71faa954e2bb35a24f62fe7c2&newSignature=b1490f9999855ac71faa954e2bb35a24f62fe7c2

https://github.com/mozilla/treeherder/blob/master/ui/js/perf.js#L220

At the least, we should pop up some kind of tooltip when a user hovers over that, to give them an indication of what's going on. The orange by itself is not intuitive. Bootstrap's tooltips might be useful here:

http://getbootstrap.com/javascript/#tooltips

Comment 1

[MikeLing]

Hi Will, I'm interesting in this bug, could I take it by myself? :)

Also, the URL you given in comment 0 seems like a little outdate, when I click  

(https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=6a3982c14382&newProject=try&newRevision=6ada351bdafc&originalSignature=b1490f9999855ac71faa954e2bb35a24f62fe7c2&newSignature=b1490f9999855ac71faa954e2bb35a24f62fe7c2)

nothing orange shows up. Could you give a similar one again? Thank you

Comment 2

[William Lachance (:wlach)]

Here's one:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=1dd64b9849ea&newProject=try&newRevision=5669a54bf902

You need to scroll down a bit to see the orange.

Comment 3

[MikeLing]

I found we had use "ui.bootstrap" in perf module, but when I put something like
> <a href="#" tooltip-placement="right" tooltip="On the Right!">right</a>

in the comparectrl.html file. No tooltip shows up when I hover on the 'right' element. So, how could I use bootstrap tooltip in Angularjs? I though angular-ui had finish the directive and I just need to use in my html file. But I just can't figure out why it doesn't work.

Comment 4

[William Lachance (:wlach)]

(In reply to MikeLing from comment #3)
> I found we had use "ui.bootstrap" in perf module, but when I put something
> like
> > <a href="#" tooltip-placement="right" tooltip="On the Right!">right</a>
> 
> in the comparectrl.html file. No tooltip shows up when I hover on the
> 'right' element. So, how could I use bootstrap tooltip in Angularjs? I
> though angular-ui had finish the directive and I just need to use in my html
> file. But I just can't figure out why it doesn't work.

I'm not sure offhand, did you look at the documentation here? https://angular-ui.github.io/bootstrap/

Comment 5

[MikeLing]

(In reply to William Lachance (:wlach) from comment #4)

> I'm not sure offhand, did you look at the documentation here?
> https://angular-ui.github.io/bootstrap/

Yep, I thought I just follow the guide of tooltip part.

Comment 6

[MikeLing]

(In reply to William Lachance (:wlach) from comment #4)

Oops, I found my terminal return error like this:

> 404 Not Found: home/mike/workspace/opensource/treeherder/ui/vendor/css/bootstrap.css.map

I think there it's where the problem is :)

Comment 7

[William Lachance (:wlach)]

Hi Mike, we need this fixed sooner than later for a performance initiative we're working on, so I'm going to steal this from you. I promise there will be other cool things to work on in the future. :)

Comment 8

[William Lachance (:wlach)]

Ok, so I wound up working on a bunch of stuff in this area, which I figured I'd roll into this bug:

1. Making the run count / run information more discoverable
2. Adding help text to the low/med/high confidence stuff

Will post a patch.

Comment 9

[William Lachance (:wlach)]

Attachment: PR to fix issues

Here's a pull request making the changes described just above. Flagging jfrench for review, avih for feedback.

Comment 10

[Avi Halachmi (:avih)]

Comment on attachment 8630737 [details] [review]
PR to fix issues

Thanks.

Comment 11

[Jonathan French (:jfrench)]

Comment on attachment 8630737 [details] [review]
PR to fix issues

r+ with whatever tweaks if any Will considers worthwhile in the PR. It seems to be behaving locally as expected :)

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/06a746c706228914b5b5c59a9781e295757b77de
Bug 1170301 - Improve display of information in compare performance

* Put # of runs directly beside average/geomeans in UI, and put a dotted
  line underneath to make it easier to pull up tooltip
* Use a bootstrap tooltip for displaying run information (clearer)
* Use a bootstrap abbreviation to make it more clear what low/med/high
  confidence actually means

Comment 13

[William Lachance (:wlach)]

Pushed, filed bug 1181686 to deal with a followup issue that was pointed out in the PR (use of "base" vs "old")

Comment 14

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/17bae7b7679823d67bc3e1fe2e44a1b2ebccf095
Bug 1170301 - Fix display of comparison detail when grunt-compiled