1170312 - Menus on Yosemite Seem to Sample the Desktop Background and the Firefox Window

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Stephen Horlander [:shorlander]]

Attachment: Combined Background + Window in Menu Blur

On Yosemite I have noticed that the background blur on context menus seems to be pulling from the desktop background image and from Firefox window and combining them.

It should sample whatever is directly underneath it.

I also noticed this when right-clicking on items in the Finder, but not anywhere else.

Attaching a screenshot but it's hard to illustrate the problem because the blur effect is so severe.

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: More Examples

More examples, my desktop background is magenta in those screenshots.

Comment 2

[Markus Stange [:mstange]]

Oh dear. It looks like NSVisualEffectMaterialTitlebar isn't a good choice for menus after all. I think NSVisualEffectMaterialLight doesn't sample from the background, so we could use that instead, but its vibrancy is much more subtle than the one regular menus use.

See also https://dxr.mozilla.org/mozilla-central/source/widget/cocoa/VibrancyManager.mm#266-272

Comment 3

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bec892a111f5

Comment 4

[Markus Stange [:mstange]]

We can fix this on 10.11 (Apple exposed the correct vibrancy material). There's a patch in bug 1187680 that does it.

Comment 5

[Stephen Horlander [:shorlander]]

(In reply to Markus Stange [:mstange] from comment #4)
> We can fix this on 10.11 (Apple exposed the correct vibrancy material).
> There's a patch in bug 1187680 that does it.

That's awesome, thank you!

Comment 6

[Markus Stange [:mstange]]

Hmm, I would have expected bug 1187680 to fix it, but it really is still happening.

Comment 7

[Markus Stange [:mstange]]

Attachment: playground, save as main.mm

I spent all day trying to figure this out, and finally found the secret.

It's -[NSWindow _backdropBleedAmount]. We need to override it to return 0.
That's what _NSPopoverWindow does, for example.

For the longest time I was looking through CGSWindowBackdrop and friends, trying to find out whether the difference was something in the backdrop properties (which also have something called a backdropBleedFraction, but that's something different!). It turns out the window's backdrop bleed amount is communicated to the window server separately from the backdrop properties, through a call to  _NSSetWindowBackdropBackgroundBleed, for example from -[NSWindow _registerBackdropView:] or from -[NSPopoverFrame shapeWindow], and that's what determines how much the desktop wallpaper contributes to the backdrop appearance.

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1170312 - Don't let the desktop background influence the vibrancy effect's backdrop for context menus.

Review commit: https://reviewboard.mozilla.org/r/222620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222620/

Comment 9

[Stephen A Pohl [:spohl]]

Comment on attachment 8953339 [details]
Bug 1170312 - Don't let the desktop background influence the vibrancy effect's backdrop for context menus.

https://reviewboard.mozilla.org/r/222620/#review228752

Should we request a public API from Apple for this?

Comment 10

[Markus Stange [:mstange]]

The public API would be to use native context menus, native tooltips and native popovers.
Which we should really do at some point...

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb3669ec7191
Don't let the desktop background influence the vibrancy effect's backdrop for context menus. r=spohl

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bb3669ec7191