Closed Bug 1170332 Opened 5 years ago Closed 5 years ago

|mach robocop SINGLE_TEST| broken after Bug 1165497

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Fallout from Bug 1164597: unfortunately, |mach robocop SINGLE_TEST| is broken.  There are few ways to address this, including:
* rolling back parts of that ticket;
* making Robocop a proper Mochitest flavour.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Summary: Fix |mach robocop SINGLE_TEST| → |mach robocop SINGLE_TEST| broken after Bug 1165497.
Summary: |mach robocop SINGLE_TEST| broken after Bug 1165497. → |mach robocop SINGLE_TEST| broken after Bug 1165497
Bug 1170332 - Fix |mach robocop SINGLE_TEST|. r?ahal,gbrown

This patch declares robocop.ini an instrumentation manifest.  It's not
currently possible to declare tests that don't correspond to files, so
we include the .java extension.  (This could be revisited.)

In |mach robocop|, we use the generic test resolving infrastructure to
select the 'instrumentation'/'robocop' flavor/subsuite tests.  In
|runtestsremote.py|, we fall back to robocop.ini, as we always have.
Attachment #8613723 - Flags: review?(gbrown)
Attachment #8613723 - Flags: review?(ahalberstadt)
Comment on attachment 8613723 [details]
MozReview Request: Bug 1170332 - Fix |mach robocop SINGLE_TEST|. r?ahal,gbrown

https://reviewboard.mozilla.org/r/9781/#review8595

The TestResolver changes look good to me! Ship it assuming the INSTRUMENTATION_MANIFEST change is ok with gbrown.
Attachment #8613723 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8613723 [details]
MozReview Request: Bug 1170332 - Fix |mach robocop SINGLE_TEST|. r?ahal,gbrown

Bug 1170332 - Fix |mach robocop SINGLE_TEST|. r?ahal,gbrown

This patch declares robocop.ini an instrumentation manifest.  It's not
currently possible to declare tests that don't correspond to files, so
we include the .java extension.  (This could be revisited.)

In |mach robocop|, we use the generic test resolving infrastructure to
select the 'instrumentation'/'robocop' flavor/subsuite tests.  In
|runtestsremote.py|, we fall back to robocop.ini, as we always have.
Attachment #8613723 - Flags: review+ → review?(ahalberstadt)
Attachment #8613723 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8613723 [details]
MozReview Request: Bug 1170332 - Fix |mach robocop SINGLE_TEST|. r?ahal,gbrown

https://reviewboard.mozilla.org/r/9781/#review8641

Ship It!
Comment on attachment 8613723 [details]
MozReview Request: Bug 1170332 - Fix |mach robocop SINGLE_TEST|. r?ahal,gbrown

https://reviewboard.mozilla.org/r/9781/#review8661

::: testing/mochitest/mach_commands.py:595
(Diff revision 2)
> +        driver.install_tests(remove=False)

Is this necessary? I find the extra messaging and pause disconcerting (but it's not a big issue).
Attachment #8613723 - Flags: review?(gbrown) → review+
https://reviewboard.mozilla.org/r/9781/#review8697

> Is this necessary? I find the extra messaging and pause disconcerting (but it's not a big issue).

It's not really necessary, but it does make it easier to add a new test.  It's a pity it does so much work (30000 files) for Robocop alone.
https://hg.mozilla.org/mozilla-central/rev/0d93a77bb153
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.