1170391 - "Reset and enable full DevTools" button doesn't enable developer mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Comment 1

[Doug Sherk (:drs) (inactive)]

Fabrice asked for someone to verify whether or not this is a Z3C-only issue. I don't have any Flames anymore to check with. I'm needinfoing myself to check once I get some new ones, but it would be better if someone else could check since it'll probably take me longer. Justin, could you take this?

Comment 2

[[:fabrice] Fabrice Desré]

We try to write the command file on /persist, or on /cache if the /persist partition doesn't exist. This is the case on the z3, so we should end up with a /cache/__post_reset_cmd__ file (see http://mxr.mozilla.org/mozilla-central/source/b2g/components/RecoveryService.js#101).

Alex, do you know if the recovery script erases /cache ?

Comment 3

[:gerard-majax]

I believe we are doing a factory reset, which is documented at https://www.codeaurora.org/cgit/quic/la/platform/bootable/recovery/tree/recovery.cpp?id=dc8da21282a0c68328d05268433d19b0f2f6a15c#n105 and implemented at https://www.codeaurora.org/cgit/quic/la/platform/bootable/recovery/tree/recovery.cpp?id=dc8da21282a0c68328d05268433d19b0f2f6a15c#n798

It explicitely destroys everything from cache partition.

Comment 4

[:gerard-majax]

Not 100% sure but we might divert and use /mnt/idd. I'll cross check to make sure we can do this.

Comment 5

[[:fabrice] Fabrice Desré]

Alex, how hard would it be to add a /persist partition back for these devices?

Comment 6

[:gerard-majax]

Adding a partition is probably not something we can do.

Comment 7

[:gerard-majax]

Adding a partition is probably not something we can do.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

[Blocking Requested - why for this release]:

I found that the permissions aren't being set at all either, so the function here isn't useful unless all the end user wants to do is reset the phone.

Comment 9

[Doug Sherk (:drs) (inactive)]

Alex, what can we do here?

Comment 10

[:gerard-majax]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #9)
> Alex, what can we do here?

Alin should be back from his business trip on Monday and be able to help me check how we can get a /persist or something that matches our needs.

Comment 11

[:gerard-majax]

So I got confirmation we can make safe use of apps_log partition as a persist one. I'd suggest we bind-mount apps_log as /persist, this way we don't need Gecko changes, but we need to reflash boot partition.

Comment 12

[:gerard-majax]

Attachment: Shinano common PR

Comment 13

[:gerard-majax]

With the PR applied, and after making sure you have reflashed boot.img and recovery.img and that recovery works,
 - Make sure ADB and Devtools is enabled in Settings, Developer
 - Tap the "Factory Reset and Enable Full DevTools"
 - After confirmation, device should reboot into recovery then reboot back

Now if you plug WebIDE it should show the device is in full devtools mode.

Comment 14

[[:fabrice] Fabrice Desré]

(In reply to Alexandre LISSY :gerard-majax from comment #11)
> So I got confirmation we can make safe use of apps_log partition as a
> persist one. I'd suggest we bind-mount apps_log as /persist, this way we
> don't need Gecko changes, but we need to reflash boot partition.

fine for me.

Comment 15

[Michael Wu [:mwu]]

Comment on attachment 8616695 [details] [review]
Shinano common PR

Sure.

Comment 16

[:gerard-majax]

Thanks!

Comment 17

[:gerard-majax]

https://github.com/mozilla-b2g/device-shinano-common/commit/dfcb155625d04f8c6188b49b9aeeaee9df79703d

Comment 18

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Aries. Going to Settings > Developer > toggle on 'Factory Reset and Enable Full DevTools' correctly enables full devtools and apps that require this functionality can then be utilized after factory resetting.

Verified on:
Device: Aries (RCA4 and OTA'ed to dogfood-latest)
BuildID: 20150715180430
Gaia: b9968cdc4a1dee49848fed6159a59c378cea062d
Gecko: 49683d4e9ebd
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0