1170454 - WebGL 2 - Vertex Array Objects are not exposed properly via DOM

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

FAIL Property either does not exist or is not a function: createVertexArray
FAIL Property either does not exist or is not a function: deleteVertexArray
FAIL Property either does not exist or is not a function: isVertexArray
FAIL Property either does not exist or is not a function: bindVertexArray

Also:

https://www.khronos.org/registry/webgl/sdk/tests/conformance2/vertex_arrays/vertex-array-object.html?webglVersion=2

Comment 1

[u480271]

Attachment: Fix up instance type for VAOs. r=smaug,r=jgilbert

Comment 2

[u480271]

try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=00ac1b55b2b2

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8614490 [details] [diff] [review]
Fix up instance type for VAOs. r=smaug,r=jgilbert

r+ for the .webidl

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8614490 [details] [diff] [review]
Fix up instance type for VAOs. r=smaug,r=jgilbert

Review of attachment 8614490 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextVAOs.cpp
@@ +9,2 @@
>  
> +namespace mozilla {

Thanks!

::: dom/canvas/WebGLContextVertexArray.cpp
@@ +50,5 @@
>  {
>      if (IsContextLost())
>          return nullptr;
>  
> +    nsRefPtr<WebGLVertexArray> globj = CreateVertexArrayImpl();

I take it we're considering this to be infallible? If so, can we comment as such near the decl?

::: dom/canvas/WebGLVertexArrayObject.cpp
@@ +14,5 @@
> +WebGLVertexArray*
> +WebGLVertexArrayObject::Create(WebGLContext* webgl)
> +{
> +  // WebGL 2: This is core in GL ES 3.
> +  MOZ_RELEASE_ASSERT(webgl->GL()->IsSupported(gl::GLFeature::vertex_array_object));

This won't happen on non-DEBUG Beta/Release. Shouldn't we return null in this case?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1c4c278b3b3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1c4c278b3b3