Closed Bug 1170454 Opened 5 years ago Closed 5 years ago

WebGL 2 - Vertex Array Objects are not exposed properly via DOM

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: kamidphish, Assigned: kamidphish)

References

()

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

FAIL Property either does not exist or is not a function: createVertexArray
FAIL Property either does not exist or is not a function: deleteVertexArray
FAIL Property either does not exist or is not a function: isVertexArray
FAIL Property either does not exist or is not a function: bindVertexArray

Also:

https://www.khronos.org/registry/webgl/sdk/tests/conformance2/vertex_arrays/vertex-array-object.html?webglVersion=2
Comment on attachment 8614490 [details] [diff] [review]
Fix up instance type for VAOs. r=smaug,r=jgilbert

r+ for the .webidl
Attachment #8614490 - Flags: review?(bugs) → review+
Comment on attachment 8614490 [details] [diff] [review]
Fix up instance type for VAOs. r=smaug,r=jgilbert

Review of attachment 8614490 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextVAOs.cpp
@@ +9,2 @@
>  
> +namespace mozilla {

Thanks!

::: dom/canvas/WebGLContextVertexArray.cpp
@@ +50,5 @@
>  {
>      if (IsContextLost())
>          return nullptr;
>  
> +    nsRefPtr<WebGLVertexArray> globj = CreateVertexArrayImpl();

I take it we're considering this to be infallible? If so, can we comment as such near the decl?

::: dom/canvas/WebGLVertexArrayObject.cpp
@@ +14,5 @@
> +WebGLVertexArray*
> +WebGLVertexArrayObject::Create(WebGLContext* webgl)
> +{
> +  // WebGL 2: This is core in GL ES 3.
> +  MOZ_RELEASE_ASSERT(webgl->GL()->IsSupported(gl::GLFeature::vertex_array_object));

This won't happen on non-DEBUG Beta/Release. Shouldn't we return null in this case?
Attachment #8614490 - Flags: review?(jgilbert) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/e1c4c278b3b3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.