1170533 - [raptor] intermittent launch test mozdevice logging failure on gaia-ci

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[Robert Wood [:rwood]]

Example: https://tools.taskcluster.net/task-inspector/#xprd6C9QQUGAfoBT3VJR2A/1

Metric                            Mean       Median     Min        Max        StdDev   p95                              
--------------------------------  ---------  ---------  ---------  ---------  -------  ---------                        
coldlaunch.contentInteractive     4453.167   4463.000   3905.000   4956.000   197.894  4864.000                         
coldlaunch.navigationLoaded       5046.933   4991.000   4639.000   5790.000   250.101  5656.000                         
coldlaunch.navigationInteractive  5049.467   4991.500   4640.000   5809.000   252.361  5657.000                         
coldlaunch.startupPathEnd         10682.567  10620.500  9546.000   12212.000  718.742  11796.000                        
coldlaunch.visuallyLoaded         12787.767  12814.000  11853.000  13982.000  439.990  13437.000                        
coldlaunch.fullyLoaded            14128.100  14076.500  12990.000  15554.000  515.535  14795.000                        
coldlaunch.uss                    21.330     22.800     16.600     23.900     2.744    23.600                           
coldlaunch.pss                    25.057     26.500     20.300     27.600     2.738    27.400                           
coldlaunch.rss                    40.137     41.600     35.400     42.700     2.734    42.400                           
                                                                                                                        
[Raptor] Testing complete                                                                                               
Tue, 02 Jun 2015 12:07:55 GMT raptor:reporter Writing report results to file                                            
Tue, 02 Jun 2015 12:07:55 GMT mozdevice:logging Stopping logging process                                                
                                                                                                                        
/home/tester/git_checkout/node_modules/mozdevice/logging.js:186                                                         
      currentStream.emit('entry', entry);                                                                               
                    ^                                                                                                   
TypeError: Cannot call method 'emit' of null                                                                            
    at /home/tester/git_checkout/node_modules/mozdevice/logging.js:186:21                                               
    at Array.forEach (native)                                                                                           
    at Socket.<anonymous> (/home/tester/git_checkout/node_modules/mozdevice/logging.js:185:21)                          
    at Socket.emit (events.js:95:17)                                                                                    
    at Socket.<anonymous> (_stream_readable.js:764:14)                                                                  
    at Socket.emit (events.js:92:17)                                                                                    
    at emitReadable_ (_stream_readable.js:426:10)                                                                       
    at emitReadable (_stream_readable.js:422:5)                                                                         
    at readableAddChunk (_stream_readable.js:165:9)                                                                     
    at Socket.Readable.push (_stream_readable.js:127:10)                                                                
========= Finished run /home/tester/bin/go-raptor.sh (results: 8, elapsed: 882 secs) (at 2015-06-02 12:07:55.804155) ===
======                                                                                                                  
[taskcluster] Unsuccessful task run with exit code: 8 completed in 1165.615

Comment 1

[Robert Wood [:rwood]]

Hmm, it seems that raptor can't read from stdout or something (maybe the adb connection was lost or something)... Eli, any ideas here? I've never seen this before.

Comment 2

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30369

Comment 3

[Robert Wood [:rwood]]

Comment on attachment 8614092 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30369

LGTM and I ran the launch test 15 separate times (on the test-startup-limit app) and didn't see the race condition/issue.

Comment 4

[:Eli Perelman]

And also to note that the patch didn't have any intermittents on Treeherder either.

Comment 5

[:Eli Perelman]

Try run: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c9789c960819933393995aec6c70214a7ebae4b8
In master: https://github.com/mozilla-b2g/gaia/commit/b6760d62e2755181152b46d9528c112105b4e2af