117055 - Comments after "." on empty line are not emailed

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect, P3)

Description

[Olav Vitters]

The additional comments after a "." on an empty line are not emailed.

Steps to reproduce:
1. Type a line of text in an additional comment.
2. Type a "." (without quotes) on an empty line
3. Type some more comments, but keep the dot on an (otherwise) empty line
4. Commit it

Reproducable: always

It is caused by calling sendmail without the "-i" option, 

From man 8 sendmail:
       -i     Ignore  dots alone on lines by themselves in incom­
              ing messages.  This should be set if you are  read­
              ing data from a file.

Not sure what version of Bugzilla Mozilla is using, so setting version to
unspecified. I've downloaded 2.14 and that version does not use the "-i" option
in the file processmail.

Comment 1

[Gervase Markham [:gerv]]

Dave?

Gerv

Comment 2

[Dave Miller [:justdave]]

Attachment: Patch

Tested locally, works just like the man page says.  How bout that. :)

Comment 3

[Andreas Franke (gone)]

Comment on attachment 67843 [details] [diff] [review]
Patch

I think I can review this. r=afranke

I have tested it locally and successfully received a comment with line with a
single dot. Don't know if it worked before, but at least it doesn't seem to
break anything.

Also, I have verified that there is no other sendmail call in a file in the
toplevel bugzilla directory.

So if it's up to me, I'd even say r=afranke x 2, but I'm not sure if I'm
allowed to review at all :-)

Comment 4

[Jacob Steenhagen]

Comment on attachment 67843 [details] [diff] [review]
Patch

I guess my only question would be, does it work on postfix?  But I really can't
test that, and I haven't found any documentation on their web site about
command line options.  But I don't see any reason why it wouldn't work, so:
r=jake

Comment 5

[Olav Vitters]

I originally tested the -i option with Postfix and it works. When I reported the
bug I only checked if Sendmail had a -i option in the man page.

From man 8 sendmail (Postfix also has a sendmail like program)
       -i     When reading a message from standard input, don´t treat a line
with only a . character as the end of input.

Comment 6

[Dave Miller [:justdave]]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.133; previous revision: 1.132
done
Checking in Token.pm;
/cvsroot/mozilla/webtools/bugzilla/Token.pm,v  <--  Token.pm
new revision: 1.5; previous revision: 1.4
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.137; previous revision: 1.136
done
Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.21; previous revision: 1.20
done
Checking in move.pl;
/cvsroot/mozilla/webtools/bugzilla/move.pl,v  <--  move.pl
new revision: 1.8; previous revision: 1.7
done
Checking in processmail;
/cvsroot/mozilla/webtools/bugzilla/processmail,v  <--  processmail
new revision: 1.77; previous revision: 1.76
done
Checking in whineatnews.pl;
/cvsroot/mozilla/webtools/bugzilla/whineatnews.pl,v  <--  whineatnews.pl
new revision: 1.6; previous revision: 1.5
done

Comment 7

[Dave Miller [:justdave]]

*** Bug 70573 has been marked as a duplicate of this bug. ***