1170581 - Updating tab counter causes performance issues

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: Screenshot 2015-06-02 11.15.06.png

Looks like the layoutIfNeeded call inside the updateTabCount is causing performance issues because it's relaying out all the subviews in order to calculate the cloned button's frame. A solution would be to statically set the button frame and not rely on the view to layout to determine the view's frame.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Screenshot 2015-06-02 11.15.18.png

Comment 2

[:Gijs (he/him)]

Does this need to be sec-sensitive?

Comment 3

[Stephan Leroux [:sleroux]]

No it doesn't. Sorry not sure how that flag got turned on :/

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/543

Added some changes to improve the startup time of the app. Removed the layoutIfNeeded call when updating the tab count as it's not needed. Also removed the showToolbars call that was happening when the user selects a tab as the toolbars will always be shown if we are selecting a new tab and not calling it avoids a layout pass.

Comment 5

[Stephan Leroux [:sleroux]]

Merged.