Fix nsSocketTransport compilation on iOS

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

(Blocks: 1 bug)

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

Simple compilation fix.
Created attachment 8614093 [details]
MozReview Request: bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer

bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer
Attachment #8614093 - Flags: review?(honzab.moz)
Attachment #8614093 - Flags: review?(honzab.moz)
Comment on attachment 8614093 [details]
MozReview Request: bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer

https://reviewboard.mozilla.org/r/9859/#review8723

::: netwerk/base/nsSocketTransport2.cpp:2908
(Diff revision 1)
> -    // OS X uses sec; only supports idle time being set.
> +    // Darwin uses sec; only supports idle time being set.

I'm probably not the best reviewer for this.  This is more a question for someone familiar with our config processing.  I'm not sure when XP_MACOSX and when XP_DARWIN are set.

Anyway, looks good to me, if this build on OSX well (don't have a machine to check.)
Comment on attachment 8614093 [details]
MozReview Request: bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer

Who the hell invented MozReview...?
Attachment #8614093 - Flags: review+
XP_DARWIN covers both OS X and iOS, where XP_MACOSX only covers OS X. The kernel is basically the same between the two, so most low-level stuff like this works fine on both. Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/2cb85653aa6f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.