1170582 - Fix nsSocketTransport compilation on iOS

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[(not currently active) Ted Mielczarek]

Simple compilation fix.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer

bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8614093 [details]
MozReview Request: bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer

https://reviewboard.mozilla.org/r/9859/#review8723

::: netwerk/base/nsSocketTransport2.cpp:2908
(Diff revision 1)
> -    // OS X uses sec; only supports idle time being set.
> +    // Darwin uses sec; only supports idle time being set.

I'm probably not the best reviewer for this.  This is more a question for someone familiar with our config processing.  I'm not sure when XP_MACOSX and when XP_DARWIN are set.

Anyway, looks good to me, if this build on OSX well (don't have a machine to check.)

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8614093 [details]
MozReview Request: bug 1170582 - Fix nsSocketTransport on iOS. r?mayhemer

Who the hell invented MozReview...?

Comment 4

[(not currently active) Ted Mielczarek]

XP_DARWIN covers both OS X and iOS, where XP_MACOSX only covers OS X. The kernel is basically the same between the two, so most low-level stuff like this works fine on both. Thanks for the review!

Comment 5

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb85653aa6f

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb85653aa6f

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2cb85653aa6f