Closed Bug 1170642 Opened 9 years ago Closed 9 years ago

[e10s] Editor tests create huge logs in e10s m2

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
e10s ? ---
firefox41 --- fixed

People

(Reporter: mccr8, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Using a script, I computed how large the logs are for tests. e10s m2 has some really huge editor tests:

   6616609 bytes from test dom/imptests/editing/selecttest/test_extend.html
   3750830 bytes from test dom/imptests/editing/selecttest/test_collapse.html
   3556562 bytes from test dom/imptests/editing/selecttest/test_addRange.html
   2162708 bytes from test dom/imptests/editing/selecttest/test_selectAllChildren.html
   1606432 bytes from test dom/imptests/html/dom/ranges/test_Range-mutations.html

Yes, that's right, one test is producing over 6MB of logs. Without e10s the largest of these, test_extend.html, is only taking about 83KB so something is going awry here.

The fun part here is that the hugeness of the log is basically one warning being spammed over and over again:

WARNING: NS_ENSURE_TRUE(node) failed: file /builds/slave/m-in-l64-d-0000000000000000000/build/src/layout/base/nsDocumentViewer.cpp, line 3538

Can that warning be made silent? Should the tests be fixed somehow?
Do you have any thoughts, Ehsan?
tracking-e10s: --- → ?
Flags: needinfo?(ehsan)
The warning appears to be this ENSURE_TRUE from nsDocumentViewer::GetInImage:

  nsCOMPtr<nsIImageLoadingContent> node;
  nsresult rv = GetPopupImageNode(getter_AddRefs(node));
  if (NS_FAILED(rv)) return rv;
  NS_ENSURE_TRUE(node, NS_ERROR_FAILURE);
Blocks: 1165515
I think we need to fix this before I can land bug 1165515.
The actual NS_ENSURE_TRUE is quite old, dating back to before bug 139905, when it was moved to its present location.
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Flags: needinfo?(ehsan)
Attachment #8614475 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/ac4e83862613
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.