1170642 - [e10s] Editor tests create huge logs in e10s m2

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Andrew McCreight [:mccr8]]

Using a script, I computed how large the logs are for tests. e10s m2 has some really huge editor tests:

   6616609 bytes from test dom/imptests/editing/selecttest/test_extend.html
   3750830 bytes from test dom/imptests/editing/selecttest/test_collapse.html
   3556562 bytes from test dom/imptests/editing/selecttest/test_addRange.html
   2162708 bytes from test dom/imptests/editing/selecttest/test_selectAllChildren.html
   1606432 bytes from test dom/imptests/html/dom/ranges/test_Range-mutations.html

Yes, that's right, one test is producing over 6MB of logs. Without e10s the largest of these, test_extend.html, is only taking about 83KB so something is going awry here.

The fun part here is that the hugeness of the log is basically one warning being spammed over and over again:

WARNING: NS_ENSURE_TRUE(node) failed: file /builds/slave/m-in-l64-d-0000000000000000000/build/src/layout/base/nsDocumentViewer.cpp, line 3538

Can that warning be made silent? Should the tests be fixed somehow?

Comment 1

[Andrew McCreight [:mccr8]]

Do you have any thoughts, Ehsan?

Comment 2

[Andrew McCreight [:mccr8]]

The warning appears to be this ENSURE_TRUE from nsDocumentViewer::GetInImage:

  nsCOMPtr<nsIImageLoadingContent> node;
  nsresult rv = GetPopupImageNode(getter_AddRefs(node));
  if (NS_FAILED(rv)) return rv;
  NS_ENSURE_TRUE(node, NS_ERROR_FAILURE);

Comment 3

[Eric Rahm [:erahm]]

I think we need to fix this before I can land bug 1165515.

Comment 4

[Andrew McCreight [:mccr8]]

The actual NS_ENSURE_TRUE is quite old, dating back to before bug 139905, when it was moved to its present location.

Comment 5

[Eric Rahm [:erahm]]

Attachment: Silence nsDocumentViewer::GetInImage warnings

Comment 6

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcc86c50d2e1

Comment 7

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4e83862613

Comment 8

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cfde6a3aba7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ac4e83862613