Closed
Bug 1170643
Opened 9 years ago
Closed 9 years ago
[Music] [Front-end] Add unit tests for ui/views/player_view.js
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S3 (24Jul)
People
(Reporter: dkuo, Assigned: hub)
References
Details
Attachments
(1 file)
Currently the unit tests for ui/views/player_view.js are not complete, so let's add more for it.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → hub
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8630756 [details] [review] [gaia] hfiguiere:bug1170643-player-view-test > mozilla-b2g:master I think all is covered.
Attachment #8630756 -
Flags: review?(dkuo)
| Comment hidden (obsolete) |
|
||
Updated•9 years ago
|
Flags: in-testsuite- → in-testsuite+
| Comment hidden (obsolete) |
|
|
Assignee | |
Updated•9 years ago
|
Status: REOPENED → ASSIGNED
Flags: in-testsuite-
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8630756 [details] [review] [gaia] hfiguiere:bug1170643-player-view-test > mozilla-b2g:master Bouncing review back to Jim. Jim, since you plan on refactoring the player view, this is relevant. I believe some of that testing will need to be change to reflect the refactoring.
Attachment #8630756 -
Flags: review?(dkuo) → review?(squibblyflabbetydoo)
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8630756 [details] [review] [gaia] hfiguiere:bug1170643-player-view-test > mozilla-b2g:master Looks good!
Attachment #8630756 -
Flags: review?(squibblyflabbetydoo) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
Merged https://github.com/mozilla-b2g/gaia/commit/1c5c3516f2d7c0b6f587c7642a23ae5b9f136da8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Target Milestone: --- → FxOS-S3 (24Jul)
You need to log in
before you can comment on or make changes to this bug.
Description
•