Closed Bug 1170799 Opened 5 years ago Closed 5 years ago

Remove unused SetBlockingOnload declaration from nsImageLoadingContent

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: jdm, Assigned: ma.steiman, Mentored)

References

Details

(Whiteboard: [lang=c++][good first bug])

Attachments

(1 file)

It doesn't appear to be implemented anywhere. No test required; if mozilla-central still compiles after removing it, that's good enough.

Code: dom/base/nsImageLoadingContent.h
Hey I would love to work on this bug, can somebody please assign it to me? Thanks!
Flags: needinfo?(josh)
After removing setBlockingOnload Firefox builds and runs cleanly.
Attachment #8614634 - Flags: review?(josh)
Assignee: nobody → ma.steiman
Flags: needinfo?(josh)
Looks great! I'm not a reviewer for this part of the code though; you'll need to choose someone from the list at https://wiki.mozilla.org/Modules/Core#Document_Object_Model (or from the suggested reviewers dropdown).
Comment on attachment 8614634 [details] [diff] [review]
Patch to Remove setBlockingOnload

Review of attachment 8614634 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 1170799 - removes unused declaration setBlockingOnLoad
Attachment #8614634 - Flags: review?(josh) → review?(mounir)
(In reply to Josh Matthews [:jdm] from comment #3)
> Looks great! I'm not a reviewer for this part of the code though; you'll
> need to choose someone from the list at
> https://wiki.mozilla.org/Modules/Core#Document_Object_Model (or from the
> suggested reviewers dropdown).

I do apologize, I saw your name in the suggested reviewers dropdown. Just for my future knowledge, are bolded names in the dropdown not reviewers and just mentors? I'm new and trying to get the hang of things so thank you for any help!
(In reply to Muhsin Ali from comment #5)
> (In reply to Josh Matthews [:jdm] from comment #3)
> > Looks great! I'm not a reviewer for this part of the code though; you'll
> > need to choose someone from the list at
> > https://wiki.mozilla.org/Modules/Core#Document_Object_Model (or from the
> > suggested reviewers dropdown).
> 
> I do apologize, I saw your name in the suggested reviewers dropdown. Just
> for my future knowledge, are bolded names in the dropdown not reviewers and
> just mentors? I'm new and trying to get the hang of things so thank you for
> any help!

That's not a problem; the mentor should always be in a good position to suggest another review if they're not appropriate. I assume bolded names are mentors, and there may or may not be overlap between the reviewers. Finally, you may want to select Ehsan or Andrea as the reviewer; I'm not sure if Mounir is active any longer. Sorry this process isn't clearer!
Comment on attachment 8614634 [details] [diff] [review]
Patch to Remove setBlockingOnload

Review of attachment 8614634 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 1170799 - removes unused declaration setBlockingOnload
Attachment #8614634 - Flags: review?(mounir) → review?(jonas)
Comment on attachment 8614634 [details] [diff] [review]
Patch to Remove setBlockingOnload

Review of attachment 8614634 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, my backlog is long enough that you should probably find another reviewer for this.
Attachment #8614634 - Flags: review?(jonas)
Attachment #8614634 - Flags: review?(bugs)
Blocks: 697230
Attachment #8614634 - Flags: review?(bugs) → review+
I don't have commit access, can someone help me with checking this in? Thanks!!
Flags: needinfo?(josh)
Add checkin-needed keyword.
Keywords: checkin-needed
Status: NEW → ASSIGNED
Flags: needinfo?(josh)
https://hg.mozilla.org/mozilla-central/rev/49dff160b431
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.