1170824 - Empty search engine bar is shown after removing non-default search engines

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: empty-search-bar.png

1) Remove all search engines in settings (except default)
2) Go back to the browser
3) Click in to the url bar
4) Type something

Expected: The search engine bar should not be visible
Actual: An empty search engine bar is shown at the bottom (See screenshot(

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1170824_empty_search_bar.patch

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Sebastian, this is fixed as part of bug 1158275, right? If so, can you dupe?

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8614464 [details] [diff] [review]
1170824_empty_search_bar.patch

Unlike what I said in the chat: This needs review and landing now that bug 1158275 is about to get closed.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is there a Try link handy for this? :)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e3b70ef6292

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Sebastian Kaspari from comment #5)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e3b70ef6292

Try run is green, except for testSettingsMenuItems on Android 4.0 but this is unrelated to these changes and is taken care of in bug 1171789.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b7eecbd81f1b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b7eecbd81f1b

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-06-17-10-54-28.png

The search engine bar is not visible after removing all search engines from settings
Tested with:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 41.0a1 (2015-06-16)