1170845 - WebGL 2 - Implement vertex divisor restrictions

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

WebGL 2 adds a constraint that at least one attributes must have a divisor of 0.

FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : There must be at least one vertex attribute with a divisor of zero when calling drawArraysInstanced
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : There must be at least one vertex attribute with a divisor of zero when calling drawElementsInstanced

Comment 1

[u480271]

Code already exists. Just need the WebGL2() check removed.

Comment 2

[u480271]

Attachment: Remove WebGL2() exclusion on instanced draw divisor check.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/835f428cd0a1

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=12349715&repo=mozilla-inbound

Comment 5

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cb082ab338a

Comment 6

[u480271]

Ugh, it's passed green in a previous try run. OK, I'll take a look at it. Thanks :tomcat

Comment 7

[u480271]

Attachment: Remove WebGL2() exclusion on instanced draw divisor check.

Comment 8

[u480271]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=34e5e46c1910

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0866912ffc06

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0866912ffc06