Closed Bug 1170845 Opened 6 years ago Closed 5 years ago

WebGL 2 - Implement vertex divisor restrictions

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: djg, Assigned: djg)

References

()

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

WebGL 2 adds a constraint that at least one attributes must have a divisor of 0.

FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : There must be at least one vertex attribute with a divisor of zero when calling drawArraysInstanced
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : There must be at least one vertex attribute with a divisor of zero when calling drawElementsInstanced
Code already exists. Just need the WebGL2() check removed.
Attachment #8636963 - Flags: review?(jgilbert) → review+
Assignee: nobody → dglastonbury
Status: NEW → ASSIGNED
sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=12349715&repo=mozilla-inbound
Flags: needinfo?(dglastonbury)
Ugh, it's passed green in a previous try run. OK, I'll take a look at it. Thanks :tomcat
Flags: needinfo?(dglastonbury)
Attachment #8636963 - Attachment is obsolete: true
Attachment #8642211 - Flags: review?(jgilbert)
Attachment #8642211 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/0866912ffc06
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.