1170852 - Remove unused method, GeckoAppShell.decodeBase64

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It's unused [1] and BitmapUtils.getBytesFromBase64 can be used instead.

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug (I recommend using the "Need more information from" box at the bottom of the page so I get a notification - it's harder to lose track of), or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/search?string=decodebase64&find=mobile%2Fandroid%2Fbase%2FGeckoAppShell&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 1

[Tyler Steiman]

Hey I'd love to work on this bug, can someone assign it to me?

Comment 2

[Tyler Steiman]

Sorry Michael I didn't see this was for Android, my mistake.

Comment 3

[Youngsun Suh [:yssuh]]

Attachment: Remove unused method, GeckoAppShell.decodeBase64

Comment 4

[Youngsun Suh [:yssuh]]

Can I work on this bug? I've uploaded a patch which removes the method.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Youngsun Suh [:yssuh] from comment #4)
> Can I work on this bug? I've uploaded a patch which removes the method.

Hi! Thank you for your patch! I'll assign the bug to you. The next step would be to get your patch reviewed[1]. So if you are happy with your patch, click on the "Details" link next to it. Then set the review flag to "?" and select Michael (bug reporter / mentor) as reviewer.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9568760a157

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8616435 [details] [diff] [review]
Remove unused method, GeckoAppShell.decodeBase64

Review of attachment 8616435 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks, Youngsun!

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree

Comment 8

[Youngsun Suh [:yssuh]]

Hi! Thanks for reviewing the patch and your kind introduction. However, it seems that one of the try server test is busted(Android 4.0 rc5). Could you guide me how can I fix this problem?

Comment 9

[Richard Newman [:rnewman]]

It's not related to your change, Youngsun, so no need.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/522672893dc1

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/522672893dc1

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/522672893dc1