Remove unused method, GeckoAppShell.decodeBase64

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcomella, Assigned: yssuh, Mentored)

Tracking

unspecified
Firefox 41
All
Android
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment)

It's unused [1] and BitmapUtils.getBytesFromBase64 can be used instead.

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug (I recommend using the "Need more information from" box at the bottom of the page so I get a notification - it's harder to lose track of), or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/search?string=decodebase64&find=mobile%2Fandroid%2Fbase%2FGeckoAppShell&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 1

3 years ago
Hey I'd love to work on this bug, can someone assign it to me?
Flags: needinfo?(michael.l.comella)

Comment 2

3 years ago
Sorry Michael I didn't see this was for Android, my mistake.
Flags: needinfo?(michael.l.comella)
(Assignee)

Comment 3

3 years ago
Created attachment 8616435 [details] [diff] [review]
Remove unused method, GeckoAppShell.decodeBase64
(Assignee)

Comment 4

3 years ago
Can I work on this bug? I've uploaded a patch which removes the method.
(In reply to Youngsun Suh [:yssuh] from comment #4)
> Can I work on this bug? I've uploaded a patch which removes the method.

Hi! Thank you for your patch! I'll assign the bug to you. The next step would be to get your patch reviewed[1]. So if you are happy with your patch, click on the "Details" link next to it. Then set the review flag to "?" and select Michael (bug reporter / mentor) as reviewer.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Assignee: nobody → zard17
(Assignee)

Updated

3 years ago
Attachment #8616435 - Flags: review?(michael.l.comella)
Comment on attachment 8616435 [details] [diff] [review]
Remove unused method, GeckoAppShell.decodeBase64

Review of attachment 8616435 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks, Youngsun!

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8616435 - Flags: review?(michael.l.comella) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

3 years ago
Hi! Thanks for reviewing the patch and your kind introduction. However, it seems that one of the try server test is busted(Android 4.0 rc5). Could you guide me how can I fix this problem?
It's not related to your change, Youngsun, so no need.
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/522672893dc1
Whiteboard: [lang=java][good first bug] → [lang=java][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/522672893dc1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Whiteboard: [lang=java][good first bug][fixed-in-fx-team] → [lang=java][good first bug]
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.