Closed Bug 1170852 Opened 4 years ago Closed 4 years ago

Remove unused method, GeckoAppShell.decodeBase64

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: mcomella, Assigned: yssuh, Mentored)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

It's unused [1] and BitmapUtils.getBytesFromBase64 can be used instead.

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

If you need any help, you can reply to this bug (I recommend using the "Need more information from" box at the bottom of the page so I get a notification - it's harder to lose track of), or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/search?string=decodebase64&find=mobile%2Fandroid%2Fbase%2FGeckoAppShell&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Hey I'd love to work on this bug, can someone assign it to me?
Flags: needinfo?(michael.l.comella)
Sorry Michael I didn't see this was for Android, my mistake.
Flags: needinfo?(michael.l.comella)
Can I work on this bug? I've uploaded a patch which removes the method.
(In reply to Youngsun Suh [:yssuh] from comment #4)
> Can I work on this bug? I've uploaded a patch which removes the method.

Hi! Thank you for your patch! I'll assign the bug to you. The next step would be to get your patch reviewed[1]. So if you are happy with your patch, click on the "Details" link next to it. Then set the review flag to "?" and select Michael (bug reporter / mentor) as reviewer.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Assignee: nobody → zard17
Attachment #8616435 - Flags: review?(michael.l.comella)
Comment on attachment 8616435 [details] [diff] [review]
Remove unused method, GeckoAppShell.decodeBase64

Review of attachment 8616435 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks, Youngsun!

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8616435 - Flags: review?(michael.l.comella) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Hi! Thanks for reviewing the patch and your kind introduction. However, it seems that one of the try server test is busted(Android 4.0 rc5). Could you guide me how can I fix this problem?
It's not related to your change, Youngsun, so no need.
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/522672893dc1
Whiteboard: [lang=java][good first bug] → [lang=java][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/522672893dc1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good first bug][fixed-in-fx-team] → [lang=java][good first bug]
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.