Closed Bug 1170852 Opened 9 years ago Closed 9 years ago

Remove unused method, GeckoAppShell.decodeBase64


(Firefox for Android Graveyard :: General, defect)

Not set


(firefox41 fixed)

Firefox 41
Tracking Status
firefox41 --- fixed


(Reporter: mcomella, Assigned: yssuh, Mentored)


(Whiteboard: [lang=java][good first bug])


(1 file)

It's unused [1] and BitmapUtils.getBytesFromBase64 can be used instead.

To start, set up a build environment - you can see the instructions here:

Then, you'll need to create a patch to upload - see

If you need any help, you can reply to this bug (I recommend using the "Need more information from" box at the bottom of the page so I get a notification - it's harder to lose track of), or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see

Thanks and happy coding! ^_^

Hey I'd love to work on this bug, can someone assign it to me?
Flags: needinfo?(michael.l.comella)
Sorry Michael I didn't see this was for Android, my mistake.
Flags: needinfo?(michael.l.comella)
Can I work on this bug? I've uploaded a patch which removes the method.
(In reply to Youngsun Suh [:yssuh] from comment #4)
> Can I work on this bug? I've uploaded a patch which removes the method.

Hi! Thank you for your patch! I'll assign the bug to you. The next step would be to get your patch reviewed[1]. So if you are happy with your patch, click on the "Details" link next to it. Then set the review flag to "?" and select Michael (bug reporter / mentor) as reviewer.

Assignee: nobody → zard17
Attachment #8616435 - Flags: review?(michael.l.comella)
Comment on attachment 8616435 [details] [diff] [review]
Remove unused method, GeckoAppShell.decodeBase64

Review of attachment 8616435 [details] [diff] [review]:

Looks good to me! Thanks, Youngsun!

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

Attachment #8616435 - Flags: review?(michael.l.comella) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Hi! Thanks for reviewing the patch and your kind introduction. However, it seems that one of the try server test is busted(Android 4.0 rc5). Could you guide me how can I fix this problem?
It's not related to your change, Youngsun, so no need.
Keywords: checkin-needed
Whiteboard: [lang=java][good first bug] → [lang=java][good first bug][fixed-in-fx-team]
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good first bug][fixed-in-fx-team] → [lang=java][good first bug]
Target Milestone: --- → Firefox 41
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.