1170904 - Remove `requires flash` checkbox as no runtime has flash

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[:Harald Kirschner :digitarald]

It's confusing for developers and I just heard from Andrew that it causes apps to be only shown on Desktop; which doesn't even have Flash.

Until Flash is sorted out on Desktop or dies out, whatever happens first, can we please hide the checkbox.

Comment 1

[:Harald Kirschner :digitarald]

ni? to get some eyes on this

Comment 2

[David Bialer [:dbialer]]

How is it confusing?  There is a tooltip that states that App will be hidden on devices that don't have Flash.    Most Flash developers should be pretty aware of the waning support for it.  But what does it mean that Desktop doesn't have Flash (you mean by default?).  

We could add more detail to the tooltip - which would say only devices that have Flash installed on them.  Or a more explicit message next to the checkbox?

Would this help?

Comment 3

[:Harald Kirschner :digitarald]

> There is a tooltip that states that App will be hidden on devices that don't have Flash.

None of our devices have flash. Even Desktop doesn't have it (bug 1131368), where the apps are shown that set the checkbox.

Comment 4

[(not reading bugmail) Nick Desaulniers [:\n]]

We should reject apps that require flash then, until bug #1131368 is resolved, if ever.

Comment 5

[David Bialer [:dbialer]]

To clarify:  when we say flash isn't supported on the desktop, does this mean that the flash plugin is not supported in WebRT and there is no plans to support it?  And Firefox for Android doesn't support it either I assume?

If so, we should outright reject apps that require flash.  Otherwise, as you point out, they would never show up if we filtered these out.

Comment 6

[(not reading bugmail) Nick Desaulniers [:\n]]

(In reply to David Bialer [:dbialer] from comment #5)
> To clarify:  when we say flash isn't supported on the desktop, does this
> mean that the flash plugin is not supported in WebRT and there is no plans
> to support it?  And Firefox for Android doesn't support it either I assume?

Flash plugin is currently not supported in Desktop WebRT.  I have a patch to re-enable it, but there was significant discussions around it by Myk and BSmedberg off-bug (email).  I'm deferring to them to make the decision to pull the trigger.  I'm not sure about Android.

Comment 7

[Mathieu Pillard [:mat]]

Part of Kill or Make Great. We chose Kill...

Comment 8

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/079d158e33846f45bac496a9916eeddfb0188b72

QA:
- Please check that app submission still works with the "this app requires flash" checkbox removed.

Comment 9

[Madalin Cotetiu]

The app submission is still working.
Closing bug.