1170916 - Sync doesn't run if there is a login error at startup

Status: RESOLVED WORKSFORME

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

If browserid_identity initializes and finds a network error during initialization, Sync doesn't start a regular schedule - it just does nothing. It should start a regular schedule in the hope/expectation the network error was transient.  (Note that if a manual sync is triggered, the schedule does then runs as normal)

This first sync is initiated by delayedAutoConnect() in policies.js, which calls autoConnect() on a timer. autoConnect() will only perform that first sync if the "status" is OK, but at this point it's error.login.failed.

I believe the correct fix here is to make browserid_identity not do those login actions on initialization, but wait for an explicit login (which is done before a sync) - it only logs in on init due to hysterical raisins. A minor complication here may be the "choose what to sync" functionality, but I'm sure we can work that out.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I'll see if this still exists.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

I can no longer reproduce this.