Closed Bug 1170987 Opened 5 years ago Closed 4 years ago

Make gfx/2d build for iOS

Categories

(Core :: Graphics, defect)

Unspecified
iOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Separate from bug 1170986 because gfx/2d is mostly standalone. The bulk of this patch is just s/XP_MACOSX/XP_DARWIN/, but there are also some bits that we can't build on iOS. The biggest one is the IOSurface stuff, as that's a private framework on iOS just like OS X, but we can't use private frameworks due to App Store guidelines on iOS.

Reading the patch I noticed I left a couple of TODOs in here, those should probably get fixed before landing, unless you're okay with filing follow-up bugs for them.
bug 1170987 - Fix gfx/2d to build on iOS. r?jrmuizel
Attachment #8614793 - Flags: review?(jmuizelaar)
Comment on attachment 8614793 [details]
MozReview Request: bug 1170987 - Fix gfx/2d to build on iOS. r?jrmuizel

Because of the new approach to IOSurfaces
Attachment #8614793 - Flags: review?(jmuizelaar) → review-
Comment on attachment 8614793 [details]
MozReview Request: bug 1170987 - Fix gfx/2d to build on iOS. r?jrmuizel

bug 1170987 - Fix gfx/2d to build on iOS. r?jrmuizel
Attachment #8614793 - Flags: review- → review?(jmuizelaar)
Attachment #8614793 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8614793 [details]
MozReview Request: bug 1170987 - Fix gfx/2d to build on iOS. r?jrmuizel

https://reviewboard.mozilla.org/r/10051/#review17981
https://hg.mozilla.org/mozilla-central/rev/3032e61bfdb7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.