1171006 - Some tests in intl/uconv/tests/unit no longer test anything

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Simon Montagu :smontagu]

I came across this while writing tests for bug 1170932: test_bug399257.js and test_bug601429.js no longer test anything, because when bug 943268 changed from using GetDecoderList to a hard-coded array it also removed the line

-  var decodingConverter = CreateScriptableConverter();

leaving decodingConverter undefined further on in the test. This didn't cause a failure, because it was expected that some charsets wouldn't have an encoder and attempting to set those charsets in the converter would throw. It's possibly a flaw in the test that each individual throw only triggers a warning and it's not considered an error if EVERY charset throws.

Comment 1

[Simon Montagu :smontagu]

Attachment: Patch

Also fixes an off-by-one error in the loop

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8614919 [details] [diff] [review]
Patch

Are some charsets lacking decoders? If not, let's simply remove try...catch from test_bug601429.js.

Comment 3

[Simon Montagu :smontagu]

(In reply to Masatoshi Kimura [:emk] from comment #2)

> Are some charsets lacking decoders? If not, let's simply remove try...catch
> from test_bug601429.js.

Yes, you're right. With the hard-coded array of charsets, we don't need the try...catch for either encoders or decoders.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f723b05e8c31

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f723b05e8c31