1171015 - Temporary disable pointer events on B2G and android platforms at Nightly

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[Maksim Lebedev]

Looks like pointer events were enabled on all platforms at Nightly.
But B2G and Android still have no good pointer events support.
So pointer events should be disabled on B2G and Android at Nightly.

Comment 1

[Maksim Lebedev]

Attachment: disable_pe_android_b2g_ver1.diff

+ Added comparison for Android and B2G platforms for enable/disable PE at Nightly
+ Added comparison for desktop platforms into interface test

Suggestions and comments and objections are very welcome.

Comment 2

[Maksim Lebedev]

Only comparison at interface test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=570b446aeab7
Both comparisons: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7372976fa99e

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8614695 [details] [diff] [review]
disable_pe_android_b2g_ver1.diff

sad that we don't have nice predefined macros for this type of case.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8614695 [details] [diff] [review]
disable_pe_android_b2g_ver1.diff

You already had r+ from smaug, why did you flag all these people? Please try and pick one reviewer.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8614695 [details] [diff] [review]
disable_pe_android_b2g_ver1.diff

Review of attachment 8614695 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +4423,5 @@
>  pref("dom.w3c_touch_events.enabled", 2);
>  #endif
>  
>  #ifdef NIGHTLY_BUILD
> +#if defined(ANDROID) || defined(MOZ_B2G)

note that ANDROID is true on b2g as well, and MOZ_B2G is true on b2g-desktop. I don't know if we care about the b2g-desktop scenario here or what.

Comment 6

[Maksim Lebedev]

(In reply to Jim Mathies [:jimm] from comment #4)
> You already had r+ from smaug, why did you flag all these people?
Because we made decision for enabling pointer events together.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> MOZ_B2G is true on
> b2g-desktop. I don't know if we care about the b2g-desktop scenario here or
> what.
Not enabling on b2g-desktop sounds good to me.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8614695 [details] [diff] [review]
disable_pe_android_b2g_ver1.diff

As I said in the other bug, I personally think it would be clearer to just put overrides to false in b2g.js and mobile.js.

Comment 9

[Maksim Lebedev]

Since bug 1166347 was backed out, all changes will be attached into bug 1166347. This bug can be closed.